Resolve after server is closed.

getsentry · Jul 18, 2023 · bf8bb57 · bf8bb57
1 parent c833faa
commit bf8bb57
Showing 1 changed file with 17 additions and 10 deletions.
diff --git a/packages/node-integration-tests/utils/index.ts b/packages/node-integration-tests/utils/index.ts
@@ -255,7 +255,9 @@ export class TestEnv {
               // Ex: Remix scope bleed tests.
               nock.cleanAll();
 
-              this._closeServer();
+              void this._closeServer().then(() => {
+                resolve(envelopes);
+              });
             }
 
             resolve(envelopes);
@@ -300,19 +302,24 @@ export class TestEnv {
 
         nock.cleanAll();
 
-        this._closeServer();
-        resolve(reqCount);
+        void this._closeServer().then(() => {
+          resolve(reqCount);
+        });
       }, options.timeout || 1000);
     });
   }
 
-  private _closeServer(): void {
-    this.server.close(() => {
-      // @ts-ignore closeAllConnections() is only available from Node v18.2.0
-      if (NODE_VERSION >= 18 && this.server.closeAllConnections) {
-        // @ts-ignore (Only available in Node 18+)
-        this.server.closeAllConnections();
-      }
+  private _closeServer(): Promise<void> {
+    return new Promise<void>(resolve => {
+      this.server.close(() => {
+        // @ts-ignore closeAllConnections() is only available from Node v18.2.0
+        if (NODE_VERSION >= 18 && this.server.closeAllConnections) {
+          // @ts-ignore (Only available in Node 18+)
+          this.server.closeAllConnections();
+        }
+      });
+
+      resolve();
     });
   }
 }