-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(core): Allow multiplexed transport to send to multiple releases (#…
…8559) The multiplexed transport can already route events to different or multiple DSNs but we also need to be able to route to specific releases too. In a page with micro-frontends, it's possible (and probably even quite common) to be using the same dependency multiple times but different versions (ie. different releases). Depending on where an error occurs we might want to send an event to `[email protected]` or `[email protected]` at the same DSN. This PR: - Adds a private `makeOverrideReleaseTransport` which can used to wrap a transport and override the release on all events - Modifies `makeMultiplexedTransport` so it now creates a transport for each unique dsn/release pair - And uses `makeOverrideReleaseTransport` whenever a release is returned from the callback
- Loading branch information
Showing
2 changed files
with
73 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,10 +6,11 @@ import type { | |
TransactionEvent, | ||
Transport, | ||
} from '@sentry/types'; | ||
import { createClientReportEnvelope, createEnvelope, dsnFromString } from '@sentry/utils'; | ||
import { TextEncoder } from 'util'; | ||
import { createClientReportEnvelope, createEnvelope, dsnFromString, parseEnvelope } from '@sentry/utils'; | ||
import { TextDecoder, TextEncoder } from 'util'; | ||
|
||
import { createTransport, getEnvelopeEndpointWithUrlEncodedAuth, makeMultiplexedTransport } from '../../../src'; | ||
import { eventFromEnvelope } from '../../../src/transports/multiplexed'; | ||
|
||
const DSN1 = 'https://[email protected]/4321'; | ||
const DSN1_URL = getEnvelopeEndpointWithUrlEncodedAuth(dsnFromString(DSN1)!); | ||
|
@@ -47,7 +48,7 @@ const CLIENT_REPORT_ENVELOPE = createClientReportEnvelope( | |
123456, | ||
); | ||
|
||
type Assertion = (url: string, body: string | Uint8Array) => void; | ||
type Assertion = (url: string, release: string | undefined, body: string | Uint8Array) => void; | ||
|
||
const createTestTransport = (...assertions: Assertion[]): ((options: BaseTransportOptions) => Transport) => { | ||
return (options: BaseTransportOptions) => | ||
|
@@ -57,7 +58,10 @@ const createTestTransport = (...assertions: Assertion[]): ((options: BaseTranspo | |
if (!assertion) { | ||
throw new Error('No assertion left'); | ||
} | ||
assertion(options.url, request.body); | ||
|
||
const event = eventFromEnvelope(parseEnvelope(request.body, new TextEncoder(), new TextDecoder()), ['event']); | ||
|
||
assertion(options.url, event?.release, request.body); | ||
resolve({ statusCode: 200 }); | ||
}); | ||
}); | ||
|
@@ -111,6 +115,21 @@ describe('makeMultiplexedTransport', () => { | |
await transport.send(ERROR_ENVELOPE); | ||
}); | ||
|
||
it('DSN and release can be overridden via match callback', async () => { | ||
expect.assertions(2); | ||
|
||
const makeTransport = makeMultiplexedTransport( | ||
createTestTransport((url, release) => { | ||
expect(url).toBe(DSN2_URL); | ||
expect(release).toBe('[email protected]'); | ||
}), | ||
() => [{ dsn: DSN2, release: '[email protected]' }], | ||
); | ||
|
||
const transport = makeTransport({ url: DSN1_URL, ...transportOptions }); | ||
await transport.send(ERROR_ENVELOPE); | ||
}); | ||
|
||
it('match callback can return multiple DSNs', async () => { | ||
expect.assertions(2); | ||
|
||
|