test: Unflake remix E2E test (#13534)

This flaked e.g. here: https://github.com/getsentry/sentry-javascript/actions/runs/10629179350/job/29465889113
getsentry · Aug 30, 2024 · eacf56b · eacf56b
1 parent 70ab8a9
commit eacf56b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/...tests/test-applications/create-remix-app-express-legacy/tests/server-transactions.test.ts b/...tests/test-applications/create-remix-app-express-legacy/tests/server-transactions.test.ts
@@ -19,6 +19,10 @@ test('Sends parameterized transaction name to Sentry', async ({ page }) => {
 });
 
 test('Sends form data with action span to Sentry', async ({ page }) => {
+  const formdataActionTransaction = waitForTransaction('create-remix-app-express-legacy', transactionEvent => {
+    return transactionEvent?.spans?.some(span => span.op === 'function.remix.action');
+  });
+
   await page.goto('/action-formdata');
 
   await page.fill('input[name=text]', 'test');
@@ -30,10 +34,6 @@ test('Sends form data with action span to Sentry', async ({ page }) => {
 
   await page.locator('button[type=submit]').click();
 
-  const formdataActionTransaction = waitForTransaction('create-remix-app-express-legacy', transactionEvent => {
-    return transactionEvent?.spans?.some(span => span.op === 'function.remix.action');
-  });
-
   const actionSpan = (await formdataActionTransaction).spans.find(span => span.op === 'function.remix.action');
 
   expect(actionSpan).toBeDefined();

diff --git a/...es/e2e-tests/test-applications/create-remix-app-express/tests/server-transactions.test.ts b/...es/e2e-tests/test-applications/create-remix-app-express/tests/server-transactions.test.ts
@@ -19,6 +19,10 @@ test('Sends parameterized transaction name to Sentry', async ({ page }) => {
 });
 
 test('Sends form data with action span', async ({ page }) => {
+  const formdataActionTransaction = waitForTransaction('create-remix-app-express', transactionEvent => {
+    return transactionEvent?.spans?.some(span => span.data && span.data['code.function'] === 'action');
+  });
+
   await page.goto('/action-formdata');
 
   await page.fill('input[name=text]', 'test');
@@ -30,10 +34,6 @@ test('Sends form data with action span', async ({ page }) => {
 
   await page.locator('button[type=submit]').click();
 
-  const formdataActionTransaction = waitForTransaction('create-remix-app-express', transactionEvent => {
-    return transactionEvent?.spans?.some(span => span.data && span.data['code.function'] === 'action');
-  });
-
   const actionSpan = (await formdataActionTransaction).spans.find(
     span => span.data && span.data['code.function'] === 'action',
   );