Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky CI]: tracing/metrics/web-vitals-lcp/test.ts:8:11 › should capture a LCP vital with element details #13115

Open
billyvg opened this issue Jul 30, 2024 · 0 comments

Comments

@billyvg
Copy link
Member

billyvg commented Jul 30, 2024

Flakiness Type

Other / Unknown

Name of Job

CI: Build & Test / Playwright (bundle_tracing_replay) Tests (pull_request)

Name of Test

tracing/metrics/web-vitals-lcp/test.ts:8:11

Link to Test Run

https://github.com/getsentry/sentry-javascript/actions/runs/10150865353/job/28069103651?pr=13072#step:10:413

Details

  1) [chromium] › tracing/metrics/web-vitals-lcp/test.ts:8:11 › should capture a LCP vital with element details. 

    Error: expect(received).toBe(expected) // Object.is equality

    Expected: "body > img"
    Received: "body > button[type=\"button\"]"

      26 |   expect(eventData.measurements?.lcp?.value).toBeDefined();
      27 |
    > 28 |   expect(eventData.contexts?.trace?.data?.['lcp.element']).toBe('body > img');
         |                                                            ^
      29 |   expect(eventData.contexts?.trace?.data?.['lcp.size']).toBe(107400);
      30 |   expect(eventData.contexts?.trace?.data?.['lcp.url']).toBe('https://example.com/path/to/image.png');
      31 | });

        at /home/runner/work/sentry-javascript/sentry-javascript/dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-lcp/test.ts:28:60
billyvg added a commit that referenced this issue Jul 30, 2024
This has been super flakey for me... its possible that we were clicking button before image has loaded so that it thinks the LCP is the button.

Closes #13115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant