Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): Fix flakey web vitals LCP test #13117

Closed
wants to merge 9 commits into from

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Jul 30, 2024

This has been super flakey for me... its possible that we were clicking button before image has loaded so that it thinks the LCP is the button.

Closes #13115

This has been super flakey for me... its possible that we were clicking button before image has loaded so that it thinks the LCP is the button.

Closes #13115
Copy link
Contributor

github-actions bot commented Jul 30, 2024

size-limit report 📦

Path Size
@sentry/browser 22.45 KB (0%)
@sentry/browser (incl. Tracing) 34.22 KB (0%)
@sentry/browser (incl. Tracing, Replay) 70.28 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.62 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 74.68 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 87.26 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 89.11 KB (0%)
@sentry/browser (incl. metrics) 26.75 KB (0%)
@sentry/browser (incl. Feedback) 39.37 KB (0%)
@sentry/browser (incl. sendFeedback) 27.06 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.7 KB (0%)
@sentry/react 25.22 KB (0%)
@sentry/react (incl. Tracing) 37.22 KB (0%)
@sentry/vue 26.6 KB (0%)
@sentry/vue (incl. Tracing) 36.06 KB (0%)
@sentry/svelte 22.58 KB (0%)
CDN Bundle 23.64 KB (0%)
CDN Bundle (incl. Tracing) 35.88 KB (0%)
CDN Bundle (incl. Tracing, Replay) 70.31 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.57 KB (0%)
CDN Bundle - uncompressed 69.37 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 106.31 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.16 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 230.99 KB (0%)
@sentry/nextjs (client) 37.07 KB (0%)
@sentry/sveltekit (client) 34.79 KB (0%)
@sentry/node 114.65 KB (0%)
@sentry/node - without tracing 89.33 KB (0%)
@sentry/aws-serverless 98.5 KB (0%)

@billyvg billyvg closed this Jul 31, 2024
@billyvg billyvg deleted the fix-tracing-flakey-web-vitals-lcp-test branch July 31, 2024 22:03
@billyvg
Copy link
Member Author

billyvg commented Jul 31, 2024

Tried out some different options (from microsoft/playwright#6046 (comment)) but none seemed to solve it. I thought it was flaking because the image wasn't fully loaded before the button click, but that doesn't seem to be the case

@billyvg billyvg restored the fix-tracing-flakey-web-vitals-lcp-test branch July 31, 2024 22:19
@billyvg billyvg reopened this Jul 31, 2024
@billyvg billyvg closed this Aug 1, 2024
@billyvg billyvg deleted the fix-tracing-flakey-web-vitals-lcp-test branch August 1, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky CI]: tracing/metrics/web-vitals-lcp/test.ts:8:11 › should capture a LCP vital with element details
1 participant