Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tracing): Fix flakey web vitals LCP test #13117

Closed
wants to merge 9 commits into from
Closed

fix(tracing): Fix flakey web vitals LCP test #13117

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
33fbefc
fix(tracing): Fix flakey web vitals LCP test
billyvg Jul 30, 2024
1761b0d
oops, move click to after image loads
billyvg Jul 30, 2024
aa2e45f
add comment
billyvg Jul 30, 2024
8892f89
try waiting for image response finish
billyvg Jul 30, 2024
216437e
try #6
billyvg Jul 30, 2024
563a89b
debug
billyvg Jul 31, 2024
6406110
debug in package
billyvg Jul 31, 2024
4ff87c3
fwd console log
billyvg Jul 31, 2024
3acfb6d
ok one last try
billyvg Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-lcp/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ sentryTest('should capture a LCP vital with element details.', async ({ browserN
if (shouldSkipTracingTest() || browserName !== 'chromium') {
sentryTest.skip();
}

page.route('**', route => route.continue());
page.route('**/path/to/image.png', async (route: Route) => {
return route.fulfill({ path: `${__dirname}/assets/sentry-logo-600x179.png` });
Expand All @@ -19,9 +18,16 @@ sentryTest('should capture a LCP vital with element details.', async ({ browserN
const [eventData] = await Promise.all([
getFirstSentryEnvelopeRequest<Event>(page),
page.goto(url),
page.locator('button').click(),
page.waitForLoadState('networkidle'),
]);

// Clicking the button before image loads will result in the button being the LCP
await page.waitForFunction(() => {
const images = Array.from(document.querySelectorAll('img'));
return images.every(img => img.naturalWidth > 0);
}),
await page.locator('button').click();

expect(eventData.measurements).toBeDefined();
expect(eventData.measurements?.lcp?.value).toBeDefined();

Expand Down
Loading