Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next.js: Fix "default" op for certain serverside transactions #13598

Closed
lforst opened this issue Sep 5, 2024 · 0 comments · Fixed by #13652
Closed

Next.js: Fix "default" op for certain serverside transactions #13598

lforst opened this issue Sep 5, 2024 · 0 comments · Fixed by #13652
Assignees
@lforst
Labels
Package: nextjs Issues related to the Sentry Nextjs SDK

Comments

@lforst
Copy link
Member

lforst commented Sep 5, 2024

Description

We haven't figured out why this happens yet but here are some examples of the transactions having a default op:

https://sentry.sentry.io/performance/trace/e7e80d610bf656ae8a0feaccd0385aa3/?dataset=transactions&eventId=7ed7154f69a64049bc4bd7df44e51445&field=title&field=project&field=user.display&field=timestamp&field=transaction.op&name=All%20Errors&project=4507657212592128&query=RSC&queryDataset=transaction-like&sort=-timestamp&source=discover&statsPeriod=1h&timestamp=1725537009&yAxis=count%28%29

It always seems to be for navigational transactions but also other cases:

https://sentry.sentry.io/performance/trace/938f2cafe045c5fb7ca8d61ea876ca69/?dataset=transactions&field=title&field=project&field=user.display&field=timestamp&field=transaction.op&name=All%20Errors&node=txn-f7765255066441cc8468b325ff76a8f8&project=4507657212592128&query=transaction.op%3Adefault&queryDataset=transaction-like&sort=-timestamp&source=discover&statsPeriod=1h&timestamp=1725536777&yAxis=count%28%29

https://sentry.sentry.io/performance/trace/4968396890d249e9f2e08a56bae52db1/?dataset=transactions&field=title&field=project&field=user.display&field=timestamp&field=transaction.op&name=All%20Errors&node=txn-887fe0cccfea4d2b8beb82c6803d3f60&project=4507657212592128&query=transaction.op%3Adefault&queryDataset=transaction-like&sort=-timestamp&source=discover&statsPeriod=1h&timestamp=1725536731&yAxis=count%28%29
@lforst lforst self-assigned this Sep 5, 2024
@AbhiPrasad AbhiPrasad added the Package: nextjs Issues related to the Sentry Nextjs SDK label Sep 9, 2024
@lforst lforst mentioned this issue Sep 10, 2024
Merged
lforst added a commit that referenced this issue Sep 10, 2024
@lforst
feat(nextjs): Improve Next.js serverside span data quality (#13652)
02290d1 
Sometimes we were sending faulty `default` ops for Next.js transactions.
This seemed to happen when the HTTP integration couldn't get a handle of
the incoming requests (yet to figure out why).

This PR:
- Backfills the op for faulty transactions
- Sets the origin of spans generated by Next.js to `auto` (I couldn't
come up with a more specific origin because the second part of it is an
op and none are satisfactory)
- Remove the `sentry.skip_span_data_inference` which is only used
internally.

This change is hard to test because it seems to happen flakily that the
http integration isn't working.

Fixes #13598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lforst lforst

Labels
Package: nextjs Issues related to the Sentry Nextjs SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(nextjs): Improve Next.js serverside span data quality getsentry/sentry-javascript
2 participants
@lforst @AbhiPrasad