Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs): Improve Next.js serverside span data quality #13652

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Sep 10, 2024

Sometimes we were sending faulty default ops for Next.js transactions. This seemed to happen when the HTTP integration couldn't get a handle of the incoming requests (yet to figure out why).

This PR:

  • Backfills the op for faulty transactions
  • Sets the origin of spans generated by Next.js to auto (I couldn't come up with a more specific origin because the second part of it is an op and none are satisfactory)
  • Remove the sentry.skip_span_data_inference which is only used internally.

This change is hard to test because it seems to happen flakily that the http integration isn't working.

Fixes #13598

@lforst lforst merged commit 02290d1 into develop Sep 10, 2024
112 checks passed
@lforst lforst deleted the lforst-op-for-rsc-reqs branch September 10, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next.js: Fix "default" op for certain serverside transactions
3 participants