-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JavaScript] Nuxt SDK #9095
Comments
See #6929 |
If you need insights from the Nuxt team at any time, please don't hesitate to reach out! 🙏 |
This is such a great news! It would be ideal that it would work on all envs. It would be great if |
@cosbgn Thanks for the input! Which libraries do you mean with "not all libraries are compatible"? |
Hi @s1gr1d, I don't have an extensive list, but for example AJV doesn't work. Workers don't use node, they use their own runtime (workerd) which is limited to web standards (similarly to deno). I think if you use only |
This is of course for the backend part of nuxt, i.e. nitro. On the frontend sentry/vue should work perfectly. |
I use Sentry on my APIs (fullstack Nuxt 3 deployment to Cloudflare pages) with the sentry/browser package on the API side to get around edge restrictions. The context Sentry devs, for cosbgn's comment, is that Nuxt 3 was built with the "deploy anywhere" ethos, so all the core packages and (new) community modules are designed to be runtime agnostic. That's where https://unjs.io/ was born from. I initially followed this guide if it helps at all with the PR in general https://www.lichter.io/articles/nuxt3-sentry-recipe (written by a core Nuxt 3 dev) |
While we may not support worker (WinterCG) runtimes from the start we will look into it eventually. We are planning to release the SDK iteratively and in stages. Prioritization of worker runtime support depends of course a bit on the demand. I added an item to the list to track. Technically we have all the building blocks available. |
I don't have any specific data, but from my understanding a big percent of nuxt apps are deployed on the edge (vercel-edge, workers, netlify edge, etc) as you get better performance for lower costs, and Nuxt pretty much "guarantees" that it will work on the edge, so it's an obvious solution. I understand if you decide not to prioritize it, I just wanted to let you know that it would be great to have it from day one. It might be as simple as using sentry/core rather than sentry/node (I don't know, just an example). Anyways, thanks for the first party package, love sentry and I would love to be able to add it to Nuxt easily! |
Great initiative! Could we also make sure that errors before the hydration are also handled? |
We want to monitor as many as possible. The first release of the SDK will cover monitoring the majority of errors and we will definitely improve it over time |
To be able to differentiate between a browser/client execution context, sentry is initialized in an external config file. An import statement in `nuxt-root.vue` is added which loads this config file. Nuxt tracking issue: #9095 --------- Co-authored-by: Abhijeet Prasad <[email protected]>
@BlazingTide If there is an issue with the experimental SDK feel free to open a new issue in our repository as it makes it easier to keep track of things 🙌 I am not sure what you mean with "sitemaps" - we don't generate sitemaps. In case you mean source maps: Yes, they are generated and uploaded automatically if you provide the sourceMapsUploadOptions and you don't need another command :) |
So the idea is to optimize the page loading performance by using nuxt scripts and prevent possible errors with SSR. For example it provides a proxy object to track events and will fire them when it is fully set up.
and
But as mentioned before: I am not sure if it would be possible to adapt the logic so it could be integrated. |
@ps-20x Re: nuxt scripts. I think we need to look into it a bit further. Superficially I can say that the upside it gives is probably very slim since the Sentry SDK needs to load very early on in the pageload for a bunch of important features (errors, performance, replay). The DX is definitely an argument. For now, I think we'll try to focus on shipping a robust SDK without using nuxt scripts but there is nothing that prevents us from migrating to that pattern later on. (also note that nuxt scripts are in beta - to some degree atleast) |
@s1gr1d are breaking changes still expected or can we work on implementation now? |
Beta means no breaking changes to the API, but it could include behavioral changes. |
Is it possible to inject the Sentry's Pinia plugin via a flag in the nuxt config as well? Looking at https://github.com/prazdevs/pinia-plugin-persistedstate/blob/main/src/runtime/plugin.ts, it looks like you need create a nuxt plugin and then add the sentry plugin to pinia in there. (And of course check first if pinia is installed, and if Sentry is enabled). |
Hi, there is a typo in the readme: sentry-javascript/packages/nuxt/README.md Line 78 in 146e7dc
It should say sentry.server.config.ts like in the docs.
|
Getting node:internal/modules/esm/resolve:265 Error [ERR_MODULE_NOT_FOUND]: Cannot find module 'web/apps/web/.output/server/node_modules/import-in-the-middle/hook.mjs' imported from web/apps/web/.output/server/index.mjs When following the installation instructions even with "overrides": { Update: Turns out in pnpm workspaces, you have to put "pnpm": { in the root package.json instead |
Thanks for trying out the beta, will update this in the docs and the readme! :) |
I'm not sure if I should leave a comment here or open a new issue, but I'm getting the following error when using this with @nuxt/content and running
I made a reproduction here. You can toggle the module in the |
In general, its better to create a new issue as it's more organized and we have a better overview :) As a temporary workaround, you can disable this with |
Currently if the sentry server is down, it crashes the build completely:
Any way to make it just a warning? |
You can configure a custom |
@ThibaultVlacich in your case you would need to add this to your nuxt config: sentry: {
unstable_sentryBundlerPluginOptions: {
errorHandler: // handle your error
}
} If you face any other problems please open up a new issue directly 🙏 |
Important
This issue is tracking progress on the Nuxt SDK. If you find bugs or problems with the
@sentry/nuxt
package please open a separate issue. Thank you!New SDK for https://nuxt.com/
There is an existing discussion: Sentry SDK for Nuxt
Nuxt uses nitro as their server, this means we'll need to have nitro support. It might make sense for us to create an OpenTelemetry instrumentation for nitro. It will also be valuable to add similar instrumentation for the other libraries Nuxt relies on:
Alpha
Beta
Stable Release
TODO but not necessary for stable
Nice to have/Stretch Goals
The text was updated successfully, but these errors were encountered: