Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): Bump action dependencies for node profiling #10473

Merged
merged 2 commits into from
Feb 6, 2024
Merged

build(ci): Bump action dependencies for node profiling #10473

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48bbaf6
build(ci): Bump action dependencies for node profiling
mydea Feb 2, 2024
7bece94
Update .github/workflows/build.yml
mydea Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,8 @@ jobs:
with:
node-version: 20
- uses: actions/setup-python@v5
with:
python-version: '3.8.10'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it complains here, but I guess it would make sense to pin some version here? Thoughs on this (and which version that should be 😅 ) @JonasBa

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mydea we can try LTS, but afaik devutils were removed in a minor python version, breaking node-gyp so we may need to reinstall some extra dependencies to be able to build the binaries.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick search, this is the issue I was talking about... Seems like 3.11 would be fine, so lets go with that

Copy link

@cclauss cclauss Feb 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue that you are quoting is closed because it fixed was by vendoring in packaging. nodejs/node-gyp#2869 (comment)

mydea marked this conversation as resolved.
Show resolved Hide resolved
- name: Restore caches
uses: ./.github/actions/restore-cache
env:
Expand Down Expand Up @@ -1316,20 +1318,20 @@ jobs:
ln -sf python3 /usr/bin/python

- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
ref: ${{ env.HEAD_COMMIT }}

- name: Restore dependency cache
uses: actions/cache/restore@v3
uses: actions/cache/restore@v4
id: restore-dependencies
with:
path: ${{ env.CACHED_DEPENDENCY_PATHS }}
key: ${{ needs.job_install_deps.outputs.dependency_cache_key }}
enableCrossOsArchive: true

- name: Restore build cache
uses: actions/cache/restore@v3
uses: actions/cache/restore@v4
id: restore-build
with:
path: ${{ env.CACHED_BUILD_PATHS }}
Expand All @@ -1348,14 +1350,14 @@ jobs:
run: yarn config set network-timeout 600000 -g

- name: Setup python
uses: actions/setup-python@v4
uses: actions/setup-python@v5
if: ${{ !contains(matrix.container, 'alpine') }}
id: python-setup
with:
python-version: '3.8.10'

- name: Setup Node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}

Expand Down
Loading