test: Port breadcrumb tests from karma runner #11436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
stephanie-anderson and
lforst
and removed request for
a team
This reads like a tiktok challenge |
Lms24
approved these changes
Apr 5, 2024
|
|
||
| // see: https://github.com/getsentry/sentry-javascript/issues/768 | ||
| sentryTest( | ||
| 'should record breadcrumb accessing the target property of an event throws an exception', |
There was a problem hiding this comment.
l: not sure but I think theres and "if" missing:
Suggested change
| 'should record breadcrumb accessing the target property of an event throws an exception', | |
| 'should record breadcrumb if accessing the target property of an event throws an exception', |
|
|
||
| const eventData = await promise; | ||
|
|
||
| expect(eventData.breadcrumbs).toHaveLength(1); |
There was a problem hiding this comment.
l: Can we check for the breadcrumb content?
Need to get syntax team to help create some content here 😄 |
This was referenced Apr 5, 2024
AbhiPrasad
added a commit
that referenced
this pull request
Apr 8, 2024
I want to remove the karma/mocha based tests in the browser package. To accomplish this, I'll be porting 1 test suite a day from the old integration tests to playwright. Today is Day 3: `packages/browser/test/integration/suites/config.js` I was surprised we never had `ignoreErrors` or `denyUrls` tests in playwright, so it's good to get the confidence that everything works here. ref #11084 day 2: #11436
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
I want to remove the karma/mocha based tests in the browser package. To accomplish this, I'll be porting 1 test suite a day from the old integration tests to playwright. Today is Day 2: `packages/browser/test/integration/suites/breadcrumbs.js` This adds console and history breadcrumb tests (which didn't exist before), and expands upon the dom and xhr/fetch tests, and cleans up some code here and there as well. ref getsentry#11084 day 1: getsentry#11412
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…ry#11449) I want to remove the karma/mocha based tests in the browser package. To accomplish this, I'll be porting 1 test suite a day from the old integration tests to playwright. Today is Day 3: `packages/browser/test/integration/suites/config.js` I was surprised we never had `ignoreErrors` or `denyUrls` tests in playwright, so it's good to get the confidence that everything works here. ref getsentry#11084 day 2: getsentry#11436
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to remove the karma/mocha based tests in the browser package. To accomplish this, I'll be porting 1 test suite a day from the old integration tests to playwright. Today is Day 2:
packages/browser/test/integration/suites/breadcrumbs.jsThis adds console and history breadcrumb tests (which didn't exist before), and expands upon the dom and xhr/fetch tests, and cleans up some code here and there as well.
ref #11084
day 1: #11412