Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(browser): Port builtin tests to playwright #11733

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

AbhiPrasad
Copy link
Member

ref #11084

This ports packages/browser/test/integration/suites/builtins.js to playwright.

It also re-organizes the eventListener test structure to be a little more organized. The new test suites added are instrumentation for xhr and requestAnimationFrame

@AbhiPrasad AbhiPrasad requested a review from a team April 22, 2024 21:16
@AbhiPrasad AbhiPrasad self-assigned this Apr 22, 2024
@AbhiPrasad AbhiPrasad requested review from stephanie-anderson and s1gr1d and removed request for a team April 22, 2024 21:16
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from one leftover only, looks good to me!

Copy link
Contributor

github-actions bot commented Apr 23, 2024

size-limit report 📦

Path Size
@sentry/browser 21.65 KB (0%)
@sentry/browser (incl. Tracing) 32.63 KB (0%)
@sentry/browser (incl. Tracing, Replay) 67.97 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.37 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.02 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.21 KB (0%)
@sentry/browser (incl. Feedback) 37.76 KB (0%)
@sentry/browser (incl. sendFeedback) 26.43 KB (0%)
@sentry/browser (incl. FeedbackAsync) 30.91 KB (0%)
@sentry/react 24.33 KB (0%)
@sentry/react (incl. Tracing) 35.53 KB (0%)
@sentry/vue 25.26 KB (0%)
@sentry/vue (incl. Tracing) 34.38 KB (0%)
@sentry/svelte 21.77 KB (0%)
CDN Bundle 23.95 KB (0%)
CDN Bundle (incl. Tracing) 33.89 KB (0%)
CDN Bundle (incl. Tracing, Replay) 67.61 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 83.44 KB (0%)
CDN Bundle - uncompressed 70.56 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 100.57 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 210.18 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 256.49 KB (0%)
@sentry/nextjs (client) 34.75 KB (0%)
@sentry/sveltekit (client) 33.13 KB (0%)
@sentry/node 152.84 KB (+0.01% 🔺)

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) April 23, 2024 16:34
@AbhiPrasad AbhiPrasad merged commit b61d820 into develop Apr 23, 2024
92 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-karma-builtin-test branch April 23, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants