Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(loader): Update Loader Script to latest #12764

Merged
merged 2 commits into from
Jul 9, 2024
Merged

test(loader): Update Loader Script to latest #12764

merged 2 commits into from
Jul 9, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jul 4, 2024 •
edited
Loading

@mydea mydea self-assigned this Jul 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser 22.28 KB (0%)
@sentry/browser (incl. Tracing) 33.43 KB (0%)
@sentry/browser (incl. Tracing, Replay) 69.18 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.51 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 73.24 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 85.85 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 87.71 KB (-0.02% 🔽)
@sentry/browser (incl. metrics) 26.57 KB (0%)
@sentry/browser (incl. Feedback) 38.92 KB (-0.09% 🔽)
@sentry/browser (incl. sendFeedback) 26.9 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.51 KB (-0.03% 🔽)
@sentry/react 25.02 KB (+0.01% 🔺)
@sentry/react (incl. Tracing) 36.48 KB (+0.04% 🔺)
@sentry/vue 26.39 KB (0%)
@sentry/vue (incl. Tracing) 35.29 KB (0%)
@sentry/svelte 22.41 KB (0%)
CDN Bundle 23.49 KB (-0.04% 🔽)
CDN Bundle (incl. Tracing) 35.18 KB (-0.03% 🔽)
CDN Bundle (incl. Tracing, Replay) 69.28 KB (-0.03% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.47 KB (-0.02% 🔽)
CDN Bundle - uncompressed 68.94 KB (-0.04% 🔽)
CDN Bundle (incl. Tracing) - uncompressed 103.96 KB (-0.03% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed 214.35 KB (-0.02% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 227.06 KB (-0.02% 🔽)
@sentry/nextjs (client) 36.35 KB (0%)
@sentry/sveltekit (client) 34.07 KB (0%)
@sentry/node 130.73 KB (-0.09% 🔽)
@sentry/node - without tracing 91.75 KB (-0.13% 🔽)
@sentry/aws-serverless 116.92 KB (-0.1% 🔽)

@mydea mydea mentioned this pull request Jul 4, 2024
Merged
mydea added a commit to getsentry/sentry that referenced this pull request Jul 8, 2024
@mydea
feat: Update Loader script to be v8 compatible (#73831)
d5e3525 
This updates the Loader Script to ensure we also check for an already
installed instance of the SDK under v8, where the global carrier
`window.__SENTRY__` has a different shape.

Part of getsentry/sentry-javascript#12187

* Tests for v8:
getsentry/sentry-javascript#12764
* Tests for v7:
getsentry/sentry-javascript#12765
@mydea mydea marked this pull request as ready for review July 8, 2024 13:53
@mydea mydea requested review from lforst, Lms24 and chargome July 8, 2024 13:54
@mydea mydea merged commit 25db805 into develop Jul 9, 2024
103 of 104 checks passed
@mydea mydea deleted the fn/update-v8-loader-script branch July 9, 2024 10:25
priscilawebdev pushed a commit to getsentry/sentry that referenced this pull request Jul 11, 2024
@mydea @priscilawebdev
feat: Update Loader script to be v8 compatible (#73831)
69e3201 
This updates the Loader Script to ensure we also check for an already
installed instance of the SDK under v8, where the global carrier
`window.__SENTRY__` has a different shape.

Part of getsentry/sentry-javascript#12187

* Tests for v8:
getsentry/sentry-javascript#12764
* Tests for v7:
getsentry/sentry-javascript#12765
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@lforst lforst Awaiting requested review from lforst

@chargome chargome Awaiting requested review from chargome

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @Lms24