test(browser): Switch from jest to vitest #13092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
lforst and
nicohrubec
and removed request for
a team
AbhiPrasad
commented
Jul 29, 2024
| @@ -226,29 +236,6 @@ describe('browserTracingIntegration', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it("trims pageload transactions to the max duration of the transaction's children", async () => { | |||
There was a problem hiding this comment.
I deleted this test because switching to the vitest timers kept it failing - but does this behaviour even apply anymore with the new changes?
Maybe @mydea you know what is happening here?
nicohrubec
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Time: 10.517 sAfter:
Duration 3.65s (transform 2.76s, setup 7ms, collect 15.44s, tests 1.36s, environment 4.96s, prepare 3.63s)We also change the folder structure of the browser unit tests, because we've removed the in-package integration tests (see #12967)
ref #11084
This change also removes
environment: 'jsdom'from the central config in favour of explicitly adding jsdom environment via the@vitest-environmentpragma to the specific test file that needs it. This should means that our tests are not polluted with jsdom globals, and that future writers have to explicitly opt-in to the behaviour.