-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: Update CHANGELOG for 8.21.0 #13110
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be used like this: ```js const getUserData = async () => { 'use server'; return await withServerActionInstrumentation('getData', () => { return { prefecture: 'Kanagawa' }; }); }; ``` Can also be used for api routes like this: ```js export async function GET() { return await withServerActionInstrumentation('getUser', () => { return json({ prefecture: 'Akita' }) }) } ```
As per https://vitest.dev/config/#globals > By default, vitest does not provide global APIs for explicitness I think we should follow vitest defaults here and explicitly import in the APIs that we need. This refactors our Astro SDK tests to do so. I also went ahead and fixed up some TS errors in some tests. This change also removes `environment: 'jsdom'` from the vite config as it seems nothing needs this for astro. This should means that our tests are not polluted with jsdom globals, and that future writers have to explicitly opt-in to the behaviour.
Adds middleware instrumentation to the `@sentry/nestjs`. The implementation lives in `@sentry/node` so that both users using `@sentry/nestjs` directly as well as users still on `@sentry/node` benefit. The instrumentation is automatic without requiring any additional setup. The idea is to hook into the Injectable decorator (every class middleware is annotated with `@Injectable` and patch the `use` method if it is implemented. Caveat: This implementation only works for class middleware, which implements the `use` method, which seems to be the standard for implementing middleware in nest. However, nest also provides functional middleware, for which this implementation does not work.
…ps.deleteFilesAfterUpload` (#13102)
misc: Sync master -> develop
…tion test setup (#13108) - Add symlinks to lazy-loaded feedback sub-integrations whenever we discover that `feedbackIntegration` is imported in a test app - Stop forwarding the CDN bundle request to the actual CDN but throw a hard error instead
ref https://github.com/nodejs/import-in-the-middle/releases/tag/import-in-the-middle-v1.11.0 Bumping this for the bug fix, we can expose the `registerOptions` in another PR.
Lms24
requested review from
a team,
lforst and
s1gr1d
and removed request for
a team
July 30, 2024 15:02
AbhiPrasad
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second try! This PR just updates the already existing 8.21.0 entry from a previous release attempt. This didn't work but we could retract everything in time and didn't publish anything yet. So starting the release under the same version should work 🤞