Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all-repos: update actions/upload-artifact to v4 #13122

Closed
wants to merge 1 commit into from

Conversation

joshuarli
Copy link
Member

@mydea
Copy link
Member

mydea commented Jul 31, 2024

This is still blocked by profling-node things I believe. cc @JonasBa do you mind checking this again? Maybe somebody could schedule some time to update this to work with v4 there, also cc'ing @AbhiPrasad as he worked on these things some too .

@JonasBa
Copy link
Member

JonasBa commented Jul 31, 2024

@mydea yes thats right. Let me try and take a look at this by eow

@JonasBa
Copy link
Member

JonasBa commented Aug 2, 2024

@mydea the profiling-node upgrades are here, however it seems other packages rely on the old merge functionality too as all the playwright tests fail. See this run where I tried bumping the other packages to v4 as well

@joshuarli
Copy link
Member Author

see getsentry/craft#552

@joshuarli joshuarli closed this Sep 17, 2024
@joshuarli joshuarli deleted the all-repos_autofix_all-repos-sed branch September 17, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants