-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Improve CI dependency checks #13175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
force-pushed
the
fn/node-integration-tests-auto
branch
from
August 2, 2024 13:03
93784ea
to
bf45cbf
Compare
mydea
changed the title
ci: Better affected check (WIP)
ci: Improve CI dependency checks
Aug 2, 2024
mydea
requested review from
lforst,
Lms24,
AbhiPrasad,
chargome,
s1gr1d and
andreiborza
August 2, 2024 13:11
AbhiPrasad
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
mydea
force-pushed
the
fn/node-integration-tests-auto
branch
2 times, most recently
from
August 5, 2024 11:21
e48b528
to
d3a5bf5
Compare
size-limit report 📦
|
Also enabled global yarn cache, and streamlines some jobs to avoid unnecessary cache restoration.
mydea
force-pushed
the
fn/node-integration-tests-auto
branch
from
August 5, 2024 14:28
d3a5bf5
to
18080ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the way we detect changed packages to rely on Nx under the hood, which should always be in sync.
Previously, we hard-coded paths in the GH workflow to determine which packages have been changed, so we can make sure to run tests accordingly.
Now, we use Nx to detect this for PRs - this takes the dependency graph into consideration and should always be up-to-date. We just need to make sure to have correct dependencies defined, also for dev packages like node-integration-tests (see addition I made there).
Note: For profiling-node, we still check the old way, because we want to avoid re-running this every time a dependency of profiling-node changes - because that depends on e.g. core and utils, and we don't want to/need to re-run this all the time.
This PR does two other things:
Example runs: