-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(utils): Fix envelope parsing edge cases #13191
Closed
Closed
Commits on Aug 2, 2024
-
fix(utils): Fix envelope parsing edge cases
This PR backports the new envelope parser in getsentry/spotlight#447 as it fixes some edge cases that the current parser does not handle. This covers binary payloads and implicit ending with EOF and line endings, and empty envelopes. The PR also adds tests cases for all these and more.
Burak Yigit Kaya committedAug 2, 2024 Configuration menu - View commit details
-
Copy full SHA for 4b778e5 - Browse repository at this point
Copy the full SHA 4b778e5View commit details -
Burak Yigit Kaya committed
Aug 2, 2024 Configuration menu - View commit details
-
Copy full SHA for b8a1f4e - Browse repository at this point
Copy the full SHA b8a1f4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fe2a15 - Browse repository at this point
Copy the full SHA 3fe2a15View commit details -
Burak Yigit Kaya committed
Aug 2, 2024 Configuration menu - View commit details
-
Copy full SHA for fca8392 - Browse repository at this point
Copy the full SHA fca8392View commit details -
Configuration menu - View commit details
-
Copy full SHA for 973ce64 - Browse repository at this point
Copy the full SHA 973ce64View commit details -
Burak Yigit Kaya committed
Aug 2, 2024 Configuration menu - View commit details
-
Copy full SHA for 52a23e3 - Browse repository at this point
Copy the full SHA 52a23e3View commit details -
Burak Yigit Kaya committed
Aug 2, 2024 Configuration menu - View commit details
-
Copy full SHA for 59580f7 - Browse repository at this point
Copy the full SHA 59580f7View commit details -
Burak Yigit Kaya committed
Aug 2, 2024 Configuration menu - View commit details
-
Copy full SHA for cc3656b - Browse repository at this point
Copy the full SHA cc3656bView commit details -
Burak Yigit Kaya committed
Aug 2, 2024 Configuration menu - View commit details
-
Copy full SHA for 2ac8e26 - Browse repository at this point
Copy the full SHA 2ac8e26View commit details -
Burak Yigit Kaya committed
Aug 2, 2024 Configuration menu - View commit details
-
Copy full SHA for d582b42 - Browse repository at this point
Copy the full SHA d582b42View commit details -
Merge branch 'develop' into byk/fix/envelope-parsing
Burak Yigit Kaya committedAug 2, 2024 Configuration menu - View commit details
-
Copy full SHA for 6f72704 - Browse repository at this point
Copy the full SHA 6f72704View commit details -
Burak Yigit Kaya committed
Aug 2, 2024 Configuration menu - View commit details
-
Copy full SHA for 96935b3 - Browse repository at this point
Copy the full SHA 96935b3View commit details -
Merge branch 'develop' into byk/fix/envelope-parsing
Burak Yigit Kaya committedAug 2, 2024 Configuration menu - View commit details
-
Copy full SHA for 04ff0f6 - Browse repository at this point
Copy the full SHA 04ff0f6View commit details -
Burak Yigit Kaya committed
Aug 2, 2024 Configuration menu - View commit details
-
Copy full SHA for ffbeccb - Browse repository at this point
Copy the full SHA ffbeccbView commit details -
Burak Yigit Kaya committed
Aug 2, 2024 Configuration menu - View commit details
-
Copy full SHA for f91bf8f - Browse repository at this point
Copy the full SHA f91bf8fView commit details -
Burak Yigit Kaya committed
Aug 2, 2024 Configuration menu - View commit details
-
Copy full SHA for 6702590 - Browse repository at this point
Copy the full SHA 6702590View commit details -
Burak Yigit Kaya committed
Aug 2, 2024 Configuration menu - View commit details
-
Copy full SHA for 49287cc - Browse repository at this point
Copy the full SHA 49287ccView commit details -
Merge branch 'develop' into byk/fix/envelope-parsing
Burak Yigit Kaya committedAug 2, 2024 Configuration menu - View commit details
-
Copy full SHA for 8b14626 - Browse repository at this point
Copy the full SHA 8b14626View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.