Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): Fix event buffering #13233

Merged
merged 8 commits into from
Aug 5, 2024
Merged

test(e2e): Fix event buffering #13233

merged 8 commits into from
Aug 5, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Aug 5, 2024 •
edited
Loading

To eliminate sources of flakiness from our e2e tests, this PR does two things:

  • Fixes a bug where we were not adding events to the event buffer that is responsible for passing past events through the event listeners.
  • Removes the forwardToSentry option which was not used anymore since we are not using prod Sentry anymore.
  • Also parallelizes the verdaccio uploading script.

@lforst lforst marked this pull request as ready for review August 5, 2024 14:43
@lforst lforst requested a review from nicohrubec August 5, 2024 14:58
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 5, 2024
View reviewed changes
dev-packages/e2e-tests/publish-packages.ts Dismissed Show dismissed Hide dismissed
@lforst lforst changed the title test(e2e): Route all buffered events through listeners test(e2e): Fix event buffering Aug 5, 2024
nicohrubec
nicohrubec approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@nicohrubec nicohrubec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

nit: maybe its worth updating the pr description to include that the verdaccio publishing is parallelized now so we have it in the history

@lforst lforst merged commit ea20c21 into develop Aug 5, 2024
96 checks passed
@lforst lforst deleted the lforst-attempt-fixing-flakey-e2e-tests branch August 5, 2024 17:25
@nicohrubec nicohrubec linked an issue Aug 5, 2024 that may be closed by this pull request
[Flaky CI]: E2E nestjs-basic Test API route transaction includes nest guard span and span started in guard is nested correctly #13176
Closed
This was referenced Aug 6, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicohrubec nicohrubec nicohrubec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lforst @nicohrubec