-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta(changelog): Update changelog for 8.24.0 #13249
Commits on Aug 5, 2024
-
ci: Cache playwright separately (#13226)
We used to include the playwright binaries in the general dependency cache, which inflated this for no reason. Now, this is not included there anymore. Additionally, I extracted the code to install & cache playwright into a composite action, making it easier to reuse it.
Configuration menu - View commit details
-
Copy full SHA for b6cf7b0 - Browse repository at this point
Copy the full SHA b6cf7b0View commit details -
Merge pull request #13234 from getsentry/master
[Gitflow] Merge master into develop
Configuration menu - View commit details
-
Copy full SHA for d6b7279 - Browse repository at this point
Copy the full SHA d6b7279View commit details -
feat(nestjs): Filter RPC exceptions (#13227)
`RpcExceptions` are always explicitly thrown in nest. Therefore, they are expected for users and should not be sent to Sentry. This PR filters these exceptions. In `@sentry/nestjs` we can simply use `instanceof RpcExceptions` to achieve this. In `@sentry/node` we do not have access to this class, so we need to check based on a property. [ref](#13190)
Configuration menu - View commit details
-
Copy full SHA for c1052ab - Browse repository at this point
Copy the full SHA c1052abView commit details -
ci: Improve CI dependency checks (#13175)
This PR updates the way we detect changed packages to rely on Nx under the hood, which should always be in sync. Previously, we hard-coded paths in the GH workflow to determine which packages have been changed, so we can make sure to run tests accordingly. Now, we use Nx to detect this for PRs - this takes the dependency graph into consideration and should always be up-to-date. We just need to make sure to have correct dependencies defined, also for dev packages like node-integration-tests (see addition I made there). Note: For profiling-node, we still check the old way, because we want to avoid re-running this every time a dependency of profiling-node changes - because that depends on e.g. core and utils, and we don't want to/need to re-run this all the time. This PR does two other things: 1. Enable global yarn cache - this may help us reduce install time on CI 2. Merge the install & build CI steps - these were run in parallel, which in reality only ate up about 50s, because this is how long it takes to restore the dependency cache, which had to happen in the build step. By merging this, min. time for install + build for a fully cached scenario is down to ~1:15 minutes, where previously it was >2 minutes across the two steps. Example runs: * Change in packages/browser: https://github.com/getsentry/sentry-javascript/actions/runs/10215948246 * Change in packages/core: https://github.com/getsentry/sentry-javascript/actions/runs/10215944443 * Change in packages/profiling-node: https://github.com/getsentry/sentry-javascript/actions/runs/10216003595
Configuration menu - View commit details
-
Copy full SHA for c71177b - Browse repository at this point
Copy the full SHA c71177bView commit details -
test(nuxt): Unit tests for event filter (#13229)
Adding more convenient unit test. There is already an E2E test for this: https://github.com/getsentry/sentry-javascript/blob/b6cf7b0cabc27a84e962f0a1e408465cc87fd961/dev-packages/e2e-tests/test-applications/nuxt-3/tests/performance.server.test.ts#L24 Also moved two files in the `test` folder to resemble the `src` folder
Configuration menu - View commit details
-
Copy full SHA for 420aaf8 - Browse repository at this point
Copy the full SHA 420aaf8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea20c21 - Browse repository at this point
Copy the full SHA ea20c21View commit details
Commits on Aug 6, 2024
-
fix(feedback): Ensure feedback can be lazy loaded in CDN bundles (#13241
) This was brought up in slack - if you use a CDN bundle (or the loader) without feedback included, and you try to lazy-load the feedbackIntegration, it fails as of today. The reason is that we check if `window.Sentry.feedbackIntegration` exists, which it _does_, because we register a shim integration for compatibility in the loader. So this PR adds a property on the shim integration which we can check for during lazy loading. While at it, I also added a missing method to the feedback integration shim.
Configuration menu - View commit details
-
Copy full SHA for 22905fe - Browse repository at this point
Copy the full SHA 22905feView commit details -
tests(e2e): Remove await timeout in nest e2e tests (#13243)
Adding a separate flush endpoint that flushes the client in the application so that we can remove the timeout await and speed up tests.
Configuration menu - View commit details
-
Copy full SHA for c8054cc - Browse repository at this point
Copy the full SHA c8054ccView commit details -
build(deps): bump nuxt from 3.11.2 to 3.12.4 in /dev-packages/e2e-tes…
…ts/test-applications/nuxt-3 (#13242) Bumps [nuxt](https://github.com/nuxt/nuxt/tree/HEAD/packages/nuxt) from 3.11.2 to 3.12.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/nuxt/nuxt/releases">nuxt's releases</a>.</em></p> <blockquote> <h2>v3.12.4</h2> <blockquote> <p>3.12.4 is the next regularly scheduled patch release.</p> </blockquote> <h2>👉 Changelog</h2> <p><a href="https://github.com/nuxt/nuxt/compare/v3.12.3...v3.12.4">compare changes</a></p> <h3>🔥 Performance</h3> <ul> <li><strong>vite:</strong> Start warmups after nitro build (<a href="https://redirect.github.com/nuxt/nuxt/pull/27963">#27963</a>)</li> <li><strong>vite:</strong> Avoid extra resolve call for <code>resolveId</code> in layers (<a href="https://redirect.github.com/nuxt/nuxt/pull/27971">#27971</a>)</li> <li><strong>kit,nuxt,schema,vite,webpack:</strong> Use explicit exports (<a href="https://redirect.github.com/nuxt/nuxt/pull/27998">#27998</a>)</li> </ul> <h3>🩹 Fixes</h3> <ul> <li><strong>schema:</strong> Resolve public alias correctly (<a href="https://redirect.github.com/nuxt/nuxt/pull/27975">#27975</a>)</li> <li><strong>nuxt:</strong> Omit rendering payload prefetch when <code>noScripts</code> (<a href="https://redirect.github.com/nuxt/nuxt/pull/27972">#27972</a>)</li> <li><strong>nuxt:</strong> Add <code>/</code> as fallback if page can't be identified (<a href="https://github.com/nuxt/nuxt/commit/e6109b226">e6109b226</a>)</li> <li><strong>ui-templates:</strong> Validate templates with <code>html-validate</code> (<a href="https://redirect.github.com/nuxt/nuxt/pull/28024">#28024</a>)</li> <li><strong>schema:</strong> Don't constrain postcss plugin options (<a href="https://redirect.github.com/nuxt/nuxt/pull/28045">#28045</a>)</li> <li><strong>kit:</strong> Remove exports from v4 branch (<a href="https://github.com/nuxt/nuxt/commit/5c8312e9b">5c8312e9b</a>)</li> <li><strong>nuxt:</strong> Use <code>unhead</code> key for ad-hoc module options (<a href="https://redirect.github.com/nuxt/nuxt/pull/28088">#28088</a>)</li> <li><strong>nuxt:</strong> Use native vue-router composables (<a href="https://redirect.github.com/nuxt/nuxt/pull/28114">#28114</a>)</li> <li><strong>kit:</strong> Ensure <code>getNuxtVersion</code> returns <code>string</code> (<a href="https://redirect.github.com/nuxt/nuxt/pull/28125">#28125</a>)</li> <li><strong>nuxt:</strong> Always prerender at least one page with crawler (<a href="https://redirect.github.com/nuxt/nuxt/pull/28131">#28131</a>)</li> <li><strong>nuxt:</strong> Consider doc <code>scroll-padding-top</code> in scrollBehavior (<a href="https://redirect.github.com/nuxt/nuxt/pull/28083">#28083</a>)</li> <li><strong>nuxt:</strong> Only warn when <code>useAsyncData</code> returns undefined (<a href="https://redirect.github.com/nuxt/nuxt/pull/28154">#28154</a>)</li> <li><strong>nuxt:</strong> Revert change to <code>getCachedData</code> null response (<a href="https://github.com/nuxt/nuxt/commit/d10cea11b">d10cea11b</a>)</li> <li><strong>schema:</strong> Don't use <code>app/</code> as <code>srcDir</code> if it doesn't exist (<a href="https://redirect.github.com/nuxt/nuxt/pull/28176">#28176</a>)</li> <li><strong>kit:</strong> Normalise <code>serverDir</code> within layers using v4 compat (<a href="https://redirect.github.com/nuxt/nuxt/pull/28177">#28177</a>)</li> <li><strong>nuxt:</strong> Allow <code>getCachedData</code> to return undefined (<a href="https://redirect.github.com/nuxt/nuxt/pull/28187">#28187</a>)</li> <li><strong>nuxt:</strong> Use <code>addEventListener</code> to register cookie store listener (<a href="https://redirect.github.com/nuxt/nuxt/pull/28193">#28193</a>)</li> <li><strong>nuxt:</strong> Merge route meta properties with scanned meta (<a href="https://redirect.github.com/nuxt/nuxt/pull/28170">#28170</a>)</li> <li><strong>nuxt:</strong> Prevent duplicate <code>set-cookie</code> headers (<a href="https://redirect.github.com/nuxt/nuxt/pull/28211">#28211</a>)</li> </ul> <h3>💅 Refactors</h3> <ul> <li><strong>schema,vite,webpack:</strong> Rework <code>postcss</code> module loading (<a href="https://redirect.github.com/nuxt/nuxt/pull/27946">#27946</a>)</li> <li><strong>nuxt:</strong> Remove <code>_registeredComponents</code> from ssrContext (<a href="https://redirect.github.com/nuxt/nuxt/pull/27819">#27819</a>)</li> <li><strong>nuxt:</strong> Use <code>errx</code> to handle dev log traces (<a href="https://redirect.github.com/nuxt/nuxt/pull/28027">#28027</a>)</li> </ul> <h3>📖 Documentation</h3> <ul> <li>Fix link (<a href="https://github.com/nuxt/nuxt/commit/83bd4fde9">83bd4fde9</a>)</li> <li>Fix Cloudflare spelling (<a href="https://redirect.github.com/nuxt/nuxt/pull/27989">#27989</a>)</li> <li>Update example to use <code>nuxtApp.runWithContext</code> (<a href="https://redirect.github.com/nuxt/nuxt/pull/28000">#28000</a>)</li> <li>Remove deprecated <code>pending</code> variable from data fetching docs (<a href="https://redirect.github.com/nuxt/nuxt/pull/28011">#28011</a>)</li> <li>Clarify xrsp danger (<a href="https://redirect.github.com/nuxt/nuxt/pull/28053">#28053</a>)</li> <li>Deprecate pending and emphasis undefined (<a href="https://redirect.github.com/nuxt/nuxt/pull/28113">#28113</a>)</li> <li>Update phrasing in route announcer (<a href="https://redirect.github.com/nuxt/nuxt/pull/28108">#28108</a>)</li> <li>Use code groups for install commands in module guide (<a href="https://redirect.github.com/nuxt/nuxt/pull/28094">#28094</a>)</li> <li>Capitalize text (<a href="https://redirect.github.com/nuxt/nuxt/pull/28056">#28056</a>)</li> <li>Mention content in upgrade guide v4 folder structure (<a href="https://redirect.github.com/nuxt/nuxt/pull/28090">#28090</a>)</li> <li>Remove a resolved issue from view transition docs (<a href="https://redirect.github.com/nuxt/nuxt/pull/28091">#28091</a>)</li> <li>Clarify navigateTo is not for nitro routes (<a href="https://redirect.github.com/nuxt/nuxt/pull/28092">#28092</a>)</li> <li>Warn about nested islands (<a href="https://redirect.github.com/nuxt/nuxt/pull/28062">#28062</a>)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/nuxt/nuxt/commit/4a1349f700aa6af14253de7363acf243ecad2c02"><code>4a1349f</code></a> v3.12.4</li> <li><a href="https://github.com/nuxt/nuxt/commit/b7da949cab3f2bc2c31f4cb8770dd185b9706a55"><code>b7da949</code></a> fix(nuxt): prevent duplicate <code>set-cookie</code> headers (<a href="https://github.com/nuxt/nuxt/tree/HEAD/packages/nuxt/issues/28211">#28211</a>)</li> <li><a href="https://github.com/nuxt/nuxt/commit/1843ffa32856300ce1781e7e0dbd56b0d2305bcd"><code>1843ffa</code></a> refactor(nuxt): use <code>errx</code> to handle dev log traces (<a href="https://github.com/nuxt/nuxt/tree/HEAD/packages/nuxt/issues/28027">#28027</a>)</li> <li><a href="https://github.com/nuxt/nuxt/commit/11264adda737726578e02b6aa9451736b442b509"><code>11264ad</code></a> fix(nuxt): merge route meta properties with scanned meta (<a href="https://github.com/nuxt/nuxt/tree/HEAD/packages/nuxt/issues/28170">#28170</a>)</li> <li><a href="https://github.com/nuxt/nuxt/commit/2417848bf2bccb0305e814944a36a439b38b7988"><code>2417848</code></a> fix(nuxt): use <code>addEventListener</code> to register cookie store listener (<a href="https://github.com/nuxt/nuxt/tree/HEAD/packages/nuxt/issues/28193">#28193</a>)</li> <li><a href="https://github.com/nuxt/nuxt/commit/a6af09eba49ea681318074195660a8c086b2f884"><code>a6af09e</code></a> fix(nuxt): allow <code>getCachedData</code> to return undefined (<a href="https://github.com/nuxt/nuxt/tree/HEAD/packages/nuxt/issues/28187">#28187</a>)</li> <li><a href="https://github.com/nuxt/nuxt/commit/d10cea11be13a29c3aa5b4c2826c14d93d57162b"><code>d10cea1</code></a> fix(nuxt): revert change to <code>getCachedData</code> null response</li> <li><a href="https://github.com/nuxt/nuxt/commit/e21f68140c13c294a1a5a1bd4641e6c0bf3d1066"><code>e21f681</code></a> fix(nuxt): only warn when <code>useAsyncData</code> returns undefined (<a href="https://github.com/nuxt/nuxt/tree/HEAD/packages/nuxt/issues/28154">#28154</a>)</li> <li><a href="https://github.com/nuxt/nuxt/commit/46a41adf27a350877f3f948d65dba13db4fe8115"><code>46a41ad</code></a> chore(deps): update vitest to v2.0.3 (3.x) (<a href="https://github.com/nuxt/nuxt/tree/HEAD/packages/nuxt/issues/28153">#28153</a>)</li> <li><a href="https://github.com/nuxt/nuxt/commit/a2fd0518ab0e1649edeb47d11aa48cf9e2c3d883"><code>a2fd051</code></a> chore(deps): update all non-major dependencies (3.x) (<a href="https://github.com/nuxt/nuxt/tree/HEAD/packages/nuxt/issues/28058">#28058</a>)</li> <li>Additional commits viewable in <a href="https://github.com/nuxt/nuxt/commits/v3.12.4/packages/nuxt">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=nuxt&package-manager=npm_and_yarn&previous-version=3.11.2&new-version=3.12.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/getsentry/sentry-javascript/network/alerts). </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for d125ff2 - Browse repository at this point
Copy the full SHA d125ff2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ddff302 - Browse repository at this point
Copy the full SHA ddff302View commit details -
ref(core): Reduce
hasTracingEnabled
size (#13232)Inlining the function removes the function declaration from the bundle.
Configuration menu - View commit details
-
Copy full SHA for 7fc479f - Browse repository at this point
Copy the full SHA 7fc479fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c7e2e2 - Browse repository at this point
Copy the full SHA 7c7e2e2View commit details