Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Add genericPool integration using opentelemetry instrumentation #13356

Closed

Commits on Aug 13, 2024

  1. feat(node): add genericPool integration using opentelemetry instrumen…

    …tation
    
    Signed-off-by: Kaung Zin Hein <[email protected]>
    Zen-cronic committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    1adaaac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    11b6ffe View commit details
    Browse the repository at this point in the history
  3. feat(node): Add genericPool integration using opentelemetry instrumen…

    …tation
    
    Set up initial code and include this instrumentation as a default integration.
    
    Signed-off-by: Kaung Zin Hein <[email protected]>
    Zen-cronic committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    69f52db View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. fix(nestjs): Exception filters in main app module are not being execu…

    …ted (getsentry#13278)
    
    [ref](getsentry#12351)
    
    This PR moves the `SentryGlobalFilter` out of the root module, which led
    to the filter overriding user exception filters in certain scenarios.
    Now there is two ways to setup sentry error monitoring:
    - If users have no catch-all exception filter in their application they
    add the `SentryGlobalFilter` as a provider in their main module.
    - If users have a catch-all exception filter (annotated with `@Catch()`
    they can use the newly introduced `SentryCaptureException()` decorator
    to capture alle exceptions caught by this filter.
    
    Testing:
    Added a new sample application to test the second setup option and
    expanded the test suite in general.
    
    Side note:
    - Also removed the `@sentry/microservices` dependency again, since it
    does not come out of the box with every nest application so we cannot
    rely on it.
    nicohrubec authored and Zen-cronic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    0c06d16 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c0239b1 View commit details
    Browse the repository at this point in the history
  3. ci: Streamline some caching (getsentry#13355)

    This streamlines some caching stuff for CI:
    
    1. Extract dependency installation & cache out into a composite action
    for reusability
    2. Updated the cache key for dependencies to only include package &
    dev-package `package.json`, not the E2E test ones.
    mydea authored and Zen-cronic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    22878c7 View commit details
    Browse the repository at this point in the history
  4. meta: Update Changelog for 8.26.0

    Lms24 authored and Zen-cronic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    6d5c5c6 View commit details
    Browse the repository at this point in the history
  5. release: 8.26.0

    getsentry-bot authored and Zen-cronic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c1a775b View commit details
    Browse the repository at this point in the history
  6. ci: Streamline browser & node unit tests (getsentry#13307)

    Instead of having to keep to separate lists of include/excludes, we now
    keep this in a single list and invert it when necessary.
    
    This way, we should no longer have problems where tests are either run
    multiple times, or not in the correct env - just add the test to the
    `browser` list in `ci-unit-tests.ts` to make sure it is not run in
    multiple node versions unnecessarily. I also added this step to the new
    package checklist.
    mydea authored and Zen-cronic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    3db3ba0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    94ad46a View commit details
    Browse the repository at this point in the history
  8. ci: Only store playwright cache on develop (getsentry#13358)

    Should reduce amount of cached data.
    mydea authored and Zen-cronic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    5e26092 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d4c7a09 View commit details
    Browse the repository at this point in the history
  10. ci: Improve size-limit CI action (getsentry#13348)

    This improves a few things in our size-limit CI action:
    
    1. Show change in bytes, in addition to the change in percentage. 
    2. Add a link below the table to the base comparison run.
    3. If we detect that the workflow run we used as base is not the latest
    one, show a warning on top.
    
    
    ![image](https://github.com/user-attachments/assets/4678ff04-a463-4579-ad91-74cbf9b7d781)
    mydea authored and Zen-cronic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    fa93e11 View commit details
    Browse the repository at this point in the history
  11. test: Ensure browser-integration-tests cannot conflict due to build (g…

    …etsentry#13338)
    
    This streamlines some stuff in our browser integration tests, to fix
    some flakiness (hopefully).
    
    The biggest change is that instead of always building into `dist` for
    each test file, each test will now build into a random subfolder, e.g.
    `dist/abc`. This way, multiple tests in a single file will never
    conflict with each other.
    
    Additionally it also streamlines some of the tests I encountered while
    looking at stuff, hopefully reducing flakes further.
    
    Closes getsentry#13321
    mydea authored and Zen-cronic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    e4129bc View commit details
    Browse the repository at this point in the history
  12. Revert "build: Bump node to 22.5.1" (getsentry#13367)

    Reverts getsentry#13118
    
    There has been quite a bit of segmentation faults in CI after this PR
    was merged.
    
    I tried spending time to look into this in more detail, but it didn't
    get far, so not worrying about this too much for now. Let's revert and
    re-examine later.
    AbhiPrasad authored and Zen-cronic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    601a6bf View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    46988f3 View commit details
    Browse the repository at this point in the history
  14. test(e2e): Fix flake in default browser e2e test (getsentry#13379)

    relax the pageload transaction assertion. Web vitals are too
    flaky to hard-assert on them and they are covered in browser integration
    tests
    Lms24 authored and Zen-cronic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    7c6d97f View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    6dbffe8 View commit details
    Browse the repository at this point in the history
  16. docs: Fix v7 changelog format and link (getsentry#13395)

    Minor changes: I realized that the formatting was broken for `v8` and
    that the migration guide wasn't linking to the specific section like
    other changelogs.
    charpeni authored and Zen-cronic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    2f11b7e View commit details
    Browse the repository at this point in the history
  17. ci: Fix crypto not being available (getsentry#13385)

    CI is angery. Crypto is only on global from Node 19 onwards.
    lforst authored and Zen-cronic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    a7aa35c View commit details
    Browse the repository at this point in the history
  18. ref: Add external contributor to CHANGELOG.md (getsentry#13400)

    This PR adds the external contributor to the CHANGELOG.md file, so that
    they are credited for their contribution. See getsentry#13395
    
    Co-authored-by: mydea <[email protected]>
    2 people authored and Zen-cronic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    ba9a704 View commit details
    Browse the repository at this point in the history
  19. docs(cloudflare): Fix spacing in README snippet (getsentry#13368)

    Fixes spacing in readme snippet
    AbhiPrasad authored and Zen-cronic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    0d3d2a1 View commit details
    Browse the repository at this point in the history
  20. feat(feedback): Improve error message for 403 errors (getsentry#13441)

    If the domain is not in `Allowed Domains` in the Sentry project
    settings, it would cause a 403 error. The default setting is `*` so this
    only occurs when the user changes these settings.
    
    Fixes getsentry#9856
    c298lee authored and Zen-cronic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    fba8cc7 View commit details
    Browse the repository at this point in the history
  21. feat(node): add genericPool integration using opentelemetry instrumen…

    …tation
    
    Signed-off-by: Kaung Zin Hein <[email protected]>
    Zen-cronic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f1182d3 View commit details
    Browse the repository at this point in the history
  22. feat(node): Add genericPool integration using opentelemetry instrumen…

    …tation
    
    Set up initial code and include this instrumentation as a default integration.
    
    Signed-off-by: Kaung Zin Hein <[email protected]>
    Zen-cronic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    43c40f8 View commit details
    Browse the repository at this point in the history
  23. test(node): Add tests for genericPoolIntegration

    Signed-off-by: Kaung Zin Hein <[email protected]>
    Zen-cronic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    37cc42e View commit details
    Browse the repository at this point in the history