Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nuxt): Wrap config in nuxt context #13457

Merged
merged 6 commits into from
Aug 27, 2024
+41 −21
Merged

feat(nuxt): Wrap config in nuxt context #13457

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eefb179
feat(nuxt): Wrap config in nuxt context
s1gr1d Aug 26, 2024
d3e4680
plugins depending
s1gr1d Aug 27, 2024
38c5341
Merge branch 'develop' into sig/nuxt-plugin-template-improved
s1gr1d Aug 27, 2024
5ff32cf
Merge branch 'develop' into sig/nuxt-plugin-template-improved
s1gr1d Aug 27, 2024
60e3c54
Merge branch 'refs/heads/develop' into sig/nuxt-plugin-template-improved
s1gr1d Aug 27, 2024
6296500
useRuntimeConfig in E2E
s1gr1d Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions packages/nuxt/src/module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,15 @@ export default defineNuxtModule<ModuleOptions>({
addPluginTemplate({
mode: 'client',
filename: 'sentry-client-config.mjs',
getContents: () =>
`import "${buildDirResolver.resolve(`/${clientConfigFile}`)}"\n` +
'import { defineNuxtPlugin } from "#imports"\n' +
'export default defineNuxtPlugin(() => {})',

// Dynamic import of config file to wrap it within a Nuxt context (here: defineNuxtPlugin)
// Makes it possible to call useRuntimeConfig() in the user-defined sentry config file
getContents: () => `
import { defineNuxtPlugin } from "#imports";

export default defineNuxtPlugin(async () => {
await import("${buildDirResolver.resolve(`/${clientConfigFile}`)}")
});`,
});

addPlugin({ src: moduleDirResolver.resolve('./runtime/plugins/sentry.client'), mode: 'client' });
Expand Down
Loading