-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node): Add socketIoIntegration
to node
#13578
base: develop
Are you sure you want to change the base?
feat(node): Add socketIoIntegration
to node
#13578
Conversation
Tests to be added. WIP |
|
||
createRunner(__dirname, 'scenario.js') | ||
.expect({ transaction: SERVER_TRANSACTION }) | ||
.expect({ transaction: CLIENT_TRANSACTION }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why the server socket and client socket are not part of the same transaction. In scenario.js, the server socket emits an event to the client, which triggers the client to send back to the server.
Update: the transactions are also not part of the same trace (different trace_id
) - verified by debugging.
93e0e53
to
8d2e189
Compare
Add otel integration and e2e tests. Signed-off-by: Kaung Zin Hein <[email protected]>
Signed-off-by: Kaung Zin Hein <[email protected]>
Signed-off-by: Kaung Zin Hein <[email protected]>
onHook(span) { | ||
addOriginToSpan(span, 'auto.socket.otel.consumer'); | ||
}, | ||
traceReserved: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should expose options such as traceReserved
, emitIgnoreEventList
, and onIgnoreEventList
for users to configure.
Resolves #13310
yarn lint
) & (yarn test
).