Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(node): Use fake timers to speed up unit tests #13607

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Sep 6, 2024

Changes the rate-limiting tests to use fake timers. This takes the test time from 24s to 4s.

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@AbhiPrasad AbhiPrasad merged commit 15dd865 into develop Sep 9, 2024
112 checks passed
@AbhiPrasad AbhiPrasad deleted the timfish/test/node-fake-timers branch September 9, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants