-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta(changelog): Update changelog for 8.32.0 #13770
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Improves the Next.js routing instrumentation by patching the Next.js router and instrumenting window popstates. A few details on this PR that might explain weird-looking logic: - The patching of the router is in a setInterval because Next.js may take a while to write the router to the window object and we don't have a cue when that has happened. - We are using a combination of patching `router.back`/`router.forward` and the `popstate` event to emit a properly named transaction, because `router.back` and `router.forward` aren't passed any useful strings we could use as txn names. - Because there is a slight delay between the `router.back`/`router.forward` calls and the `popstate` event, we temporarily give the navigation span an invalid name that we use as an indicator to drop if one may leak through.
Removes alpha note from cloudflare sdk readme. ref #12620
This fails e.g. here https://github.com/getsentry/sentry-javascript/actions/runs/10964808053/job/30450399966 for prereleases right now, because the prerelease in the verdaccio registry does not match the required range.
Moved assertions inside a conditional where the `lcp.element` is the image, not the button (It's worked around like this in other test suites). I guess this flakiness is behavioural not about the tests.
#13748) Adds a new option `attachErrorHandler` to the `vueIntegration`. This option is used in the Nuxt SDK to prevent wrapping the existing Nuxt error handler. Instead, the errors are captured in the Nuxt hooks. fixes: #12515 --------- Co-authored-by: Lukas Stracke <[email protected]>
…13711) Fixes #13359 - [x] If you've added code that should be tested, please add tests. - [x] Ensure your code lints and the test suite passes (`yarn lint`) & (`yarn test`). --------- Signed-off-by: Kaung Zin Hein <[email protected]> Co-authored-by: Luca Forstner <[email protected]>
Makes some modifications to `browser` spans: - Moves the description of navigation related `browser` spans into the op, e.g. `browser - cache` -> `browser.cache` - Sets the description to the `performanceEntry` objects' `names`, in this context it is the URL of the page This change is being made so that these `browser` spans can be ingested and grouped. Currently, all browser spans are grouped into a singular `browser` span, despite each of the operations that these span represent doing very different things. This will improve the experience in the Spans tab of transaction summary and span summary, since we will be able to have proper groupings for `browser` spans.
resolves #13312 Before submitting a pull request, please take a look at our [Contributing](https://github.com/getsentry/sentry-javascript/blob/master/CONTRIBUTING.md) guidelines and verify: - [x] If you've added code that should be tested, please add tests. - [x] Ensure your code lints and the test suite passes (`yarn lint`) & (`yarn test`).
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #13711 Co-authored-by: lforst <[email protected]>
…plication ref in global filter (#13673)
) Found this while working on #13763. Oops, the node-otel-without-tracing E2E test was not running on CI, we forgot to add it there - and it was actually failing since we switched to the new undici instrumentation :O This PR ensures to add it to CI, and also fixes it. The main change for this is to ensure we do not emit any spans when tracing is disabled, while still ensuring that trace propagation works as expected for this case. I also pulled some general changes into this, which ensure that we patch both `http.get` and `http.request` properly.
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #13673 Co-authored-by: chargome <[email protected]>
…cing without Performance mode (#13753) Fix a bug in Core that surfaced in Node apps configured for Tracing without Performance. Previously, we'd incorrectly add `sampled: false` flag when creating the DSC from an active span if the application was configured for TwP. This is possible because in TwP, Otel still emits non-recording spans for the incoming requests. Our implementation in Core didn't account for this edge case yet.
mydea
changed the title
Prepare release/8.32.0
meta(changelog): Update changelog for 8.32.0
Sep 24, 2024
mydea
approved these changes
Sep 24, 2024
This fails sometimes (e.g. https://github.com/getsentry/sentry-javascript/actions/runs/11016486300/job/30592307032), probably due to tiny timing issues.
Lms24
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new changelog entry LGTM!
meta: Merge master into develop
Follow up to #13772, which kind of messed this up a bit...
chargome
force-pushed
the
prepare-release/8.32.0
branch
from
September 25, 2024 07:36
be902d5
to
0a21708
Compare
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.