Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta(changelog): Update changelog for 8.32.0 #13770

Merged
merged 21 commits into from
Sep 25, 2024
Merged

Conversation

chargome
Copy link
Member

No description provided.

lforst and others added 16 commits September 20, 2024 09:52
)

Improves the Next.js routing instrumentation by patching the Next.js
router and instrumenting window popstates.

A few details on this PR that might explain weird-looking logic:
- The patching of the router is in a setInterval because Next.js may
take a while to write the router to the window object and we don't have
a cue when that has happened.
- We are using a combination of patching `router.back`/`router.forward`
and the `popstate` event to emit a properly named transaction, because
`router.back` and `router.forward` aren't passed any useful strings we
could use as txn names.
- Because there is a slight delay between the
`router.back`/`router.forward` calls and the `popstate` event, we
temporarily give the navigation span an invalid name that we use as an
indicator to drop if one may leak through.
Adds the PR link to the changelog for easier access.

An entry would look like this:

> - feat(node): Add `dataloader` integration
([#13664](#13664))
> ```
> - feat(node): Add `dataloader` integration
([#13664](#13664))
> ```
Removes alpha note from cloudflare sdk readme.

ref #12620
This fails e.g. here
https://github.com/getsentry/sentry-javascript/actions/runs/10964808053/job/30450399966
for prereleases right now, because the prerelease in the verdaccio
registry does not match the required range.
Moved assertions inside a conditional where the `lcp.element` is the
image, not the button (It's worked around like this in other test
suites). I guess this flakiness is behavioural not about the tests.
#13748)

Adds a new option `attachErrorHandler` to the `vueIntegration`. This
option is used in the Nuxt SDK to prevent wrapping the existing Nuxt
error handler. Instead, the errors are captured in the Nuxt hooks.

fixes: #12515

---------

Co-authored-by: Lukas Stracke <[email protected]>
…13711)

Fixes #13359 

- [x] If you've added code that should be tested, please add tests.
- [x] Ensure your code lints and the test suite passes (`yarn lint`) &
(`yarn test`).

---------

Signed-off-by: Kaung Zin Hein <[email protected]>
Co-authored-by: Luca Forstner <[email protected]>
Makes some modifications to `browser` spans:

- Moves the description of navigation related `browser` spans into the
op, e.g. `browser - cache` -> `browser.cache`
- Sets the description to the `performanceEntry` objects' `names`, in
this context it is the URL of the page

This change is being made so that these `browser` spans can be ingested
and grouped. Currently, all browser spans are grouped into a singular
`browser` span, despite each of the operations that these span represent
doing very different things.

This will improve the experience in the Spans tab of transaction summary
and span summary, since we will be able to have proper groupings for
`browser` spans.
resolves #13312

Before submitting a pull request, please take a look at our

[Contributing](https://github.com/getsentry/sentry-javascript/blob/master/CONTRIBUTING.md)
guidelines and verify:

- [x] If you've added code that should be tested, please add tests.
- [x] Ensure your code lints and the test suite passes (`yarn lint`) &
(`yarn test`).
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #13711

Co-authored-by: lforst <[email protected]>
)

Found this while working on
#13763.

Oops, the node-otel-without-tracing E2E test was not running on CI, we
forgot to add it there - and it was actually failing since we switched
to the new undici instrumentation :O

This PR ensures to add it to CI, and also fixes it. The main change for
this is to ensure we do not emit any spans when tracing is disabled,
while still ensuring that trace propagation works as expected for this
case.

I also pulled some general changes into this, which ensure that we patch
both `http.get` and `http.request` properly.
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #13673

Co-authored-by: chargome <[email protected]>
…cing without Performance mode (#13753)

Fix a bug in Core that surfaced in Node apps configured for
Tracing without Performance.

Previously, we'd incorrectly add `sampled: false` flag when creating the
DSC from an active span if the application was configured for TwP. This
is possible because in TwP, Otel still emits non-recording spans for the
incoming requests. Our implementation in Core didn't account for this
edge case yet.
@chargome chargome requested review from a team as code owners September 24, 2024 15:12
@mydea mydea changed the title Prepare release/8.32.0 meta(changelog): Update changelog for 8.32.0 Sep 24, 2024
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new changelog entry LGTM!

mydea and others added 3 commits September 25, 2024 08:52
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.63 KB added added
@sentry/browser - with treeshaking flags 21.42 KB added added
@sentry/browser (incl. Tracing) 34.86 KB added added
@sentry/browser (incl. Tracing, Replay) 71.36 KB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.79 KB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 75.71 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 88.48 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.36 KB added added
@sentry/browser (incl. metrics) 26.91 KB added added
@sentry/browser (incl. Feedback) 39.77 KB added added
@sentry/browser (incl. sendFeedback) 27.29 KB added added
@sentry/browser (incl. FeedbackAsync) 32.08 KB added added
@sentry/react 25.38 KB added added
@sentry/react (incl. Tracing) 37.84 KB added added
@sentry/vue 26.8 KB added added
@sentry/vue (incl. Tracing) 36.75 KB added added
@sentry/svelte 22.76 KB added added
CDN Bundle 23.94 KB added added
CDN Bundle (incl. Tracing) 36.63 KB added added
CDN Bundle (incl. Tracing, Replay) 71.13 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 76.44 KB added added
CDN Bundle - uncompressed 70.14 KB added added
CDN Bundle (incl. Tracing) - uncompressed 108.6 KB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 220.48 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 233.69 KB added added
@sentry/nextjs (client) 37.8 KB added added
@sentry/sveltekit (client) 35.43 KB added added
@sentry/node 124.92 KB added added
@sentry/node - without tracing 93.57 KB added added
@sentry/aws-serverless 103.28 KB added added

@chargome chargome merged commit ae901c3 into master Sep 25, 2024
129 checks passed
@chargome chargome deleted the prepare-release/8.32.0 branch September 25, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.