-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta(changelog): Update changelog for 8.34.0 #13941
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….33.1 [Gitflow] Sync master and develop
…13854) Add support for wasm WebAssembly.Exception (uncaught exception in emscripten). ## References - [WebAssembly.Exception | MDN Web Docs](https://developer.mozilla.org/en-US/docs/WebAssembly/JavaScript_interface/Exception) - #13787 --------- Co-authored-by: s1gr1d <[email protected]> Co-authored-by: Sigrid Huemer <[email protected]> Co-authored-by: Luca Forstner <[email protected]>
Managed to stop flakes locally with these updates
`Runtime.releaseObject` can throw. I've reworked it to simplify and so that errors are caught. After a lot of testing, I've removed the memory leak test. I've tested this PR extensively on Node v20 + v22 and while memory usage does peak at ~350MB, it doesn't get above that after 15 minute of 1k errors per second. Memory usage varies from 150-300MB but I've concluded it's not actually leaking.
Closes #13879 I opted to not export a shim for this in non-Replay bundles, as this is already more advanced usage... We can still opt to export shims here later if needed.
Bumps [dkhunt27/action-nx-affected-list](https://github.com/dkhunt27/action-nx-affected-list) from 5.3 to 6.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dkhunt27/action-nx-affected-list/releases">dkhunt27/action-nx-affected-list's releases</a>.</em></p> <blockquote> <h2>v6.1</h2> <p>fixed bug to handle spaces and newlines</p> <h2>v6.0</h2> <p>Added affectedToIgnore</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dkhunt27/action-nx-affected-list/commit/49c7295522987f433e781ed7f47c55a2274d7259"><code>49c7295</code></a> updated to handle spaces and newlines</li> <li><a href="https://github.com/dkhunt27/action-nx-affected-list/commit/016be537086b0710776dc82cbd7ea69b0e61c10e"><code>016be53</code></a> Merge pull request <a href="https://redirect.github.com/dkhunt27/action-nx-affected-list/issues/227">#227</a> from dkhunt27/ignore</li> <li><a href="https://github.com/dkhunt27/action-nx-affected-list/commit/eefa673f810ac3f05880c52ecaa74cf6940101cf"><code>eefa673</code></a> build dist</li> <li><a href="https://github.com/dkhunt27/action-nx-affected-list/commit/02295e48c3f48338d36dd78db4a30e19b817e4b7"><code>02295e4</code></a> fix lint errors</li> <li><a href="https://github.com/dkhunt27/action-nx-affected-list/commit/9fc7876e6b15c8c7a2524601c9fd060675a797f3"><code>9fc7876</code></a> kept eslint at 8 and nx at 17 for now</li> <li><a href="https://github.com/dkhunt27/action-nx-affected-list/commit/3dcee21c036989449527fb8dd85ede09983d4df9"><code>3dcee21</code></a> updated lib versions</li> <li><a href="https://github.com/dkhunt27/action-nx-affected-list/commit/4f3675f3e35766c82c5889c677894659a2c917e8"><code>4f3675f</code></a> added affectedToIgnore</li> <li>See full diff in <a href="https://github.com/dkhunt27/action-nx-affected-list/compare/v5.3...v6.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=dkhunt27/action-nx-affected-list&package-manager=github_actions&previous-version=5.3&new-version=6.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
I noticed multiple times, e.g. #13883, that the external contributor PRs do not trigger CI automatically. I think this is because stuff that is triggered by GITHUB_TOKEN does not trigger CI. So I am updating this to use the repo scoped token instead, let's see if that works.
This should not have changed fundamentally since v7, but it is confusing that it says v7.xxx in the header, so updating this to be current again. Closes #13878
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #13876 Co-authored-by: mydea <[email protected]>
Before the v8 release we decided to use `globalThis` to simplify access the global object across all platforms and contexts. `globalThis` is not ES2018 but we didn't consider this when the minimum supported browser versions were documented.
Moving function to be used in other SDKs that can be deployed to Vercel.
I had a situation once that I couldn't reproduce where I encountered Sentry spans being sent with Next.js OTEL tracing. This PR ignores those spans.
POST requests and such can also emit `_not-found` transactions. We want to drop those.
Noticed this by chance, due to the way `generateInstrumentOnce` works, we need to pass in the fully formed config.
Cleans up the instrumentation for pages router API routes and removes some dead code.
[Nuxt module builder](https://github.com/nuxt/module-builder) uses the closest `tsconfig.json` and this had `"declaration": false`. I added another `tsconfig.json` closer to the module to generate those declarations. fixes #13899
Removes the incorrect root span check guarding the trace `<meta>` tag injection. With this fix, trace data is now also injected for Tracing Without Performance scenarios where there is no active span. closes #13106
…13900) It is possible that an error gets thrown outside of flushing (we should be catching exceptions in flush and do no re-throw), which our core SDK error handler would catch due to global rejection handler and trigger replay SDK to flush again.
…tchers (#13390) SvelteKit narrows the type of `event.params` based on ParamMatchers that are defined in the path, by making the function generic we can respect the narrowed type
Saw this while debugging, this should not have a big effect since the fallback buffer should be relatively small.
Pulls in upstream rrweb commits, see getsentry/rrweb#220
…#13928) Looks like we missed adding the `build` dir to the template path of `requestAsyncStorageShim` in the NextJS SDK when we changed the package-internal directory structure a while ago (IIRC this was pre-v8 but not sure actually) I'm a bit surprised that this works at all, given we use `exports` conditions and this is a path to a specific file not covered by any `exports` entry. But I guess webpack can handle this still. EDIT: Well turns out, this doesn't work. We'll need to add the `exports` entries. fixes #13925 closes #13926 closes #13927
…t Next.js v15.0.0-canary.180 and higher (#13920)
…13844) Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6.1.0 to 7.0.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/peter-evans/create-pull-request/releases">peter-evans/create-pull-request's releases</a>.</em></p> <blockquote> <h2>Create Pull Request v7.0.5</h2> <p>⚙️ Fixes an issue with commit signing to allow it to support symlinks</p> <h2>What's Changed</h2> <ul> <li>fix: support symlinks when commit signing by <a href="https://github.com/peter-evans"><code>@peter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3359">peter-evans/create-pull-request#3359</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-pull-request/compare/v7.0.4...v7.0.5">https://github.com/peter-evans/create-pull-request/compare/v7.0.4...v7.0.5</a></p> <h2>Create Pull Request v7.0.4</h2> <p>⚙️ Fixes an issue with commit signing to allow it to support submodules</p> <h2>What's Changed</h2> <ul> <li>docs: correct suggestion for bot setup by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3342">peter-evans/create-pull-request#3342</a></li> <li>build(deps-dev): bump <code>@types/jest</code> from 29.5.12 to 29.5.13 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3343">peter-evans/create-pull-request#3343</a></li> <li>build(deps-dev): bump eslint from 8.57.0 to 8.57.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3344">peter-evans/create-pull-request#3344</a></li> <li>fix: support submodules when commit signing by <a href="https://github.com/peter-evans"><code>@peter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3354">peter-evans/create-pull-request#3354</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/henryiii"><code>@henryiii</code></a> made their first contribution in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3342">peter-evans/create-pull-request#3342</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-pull-request/compare/v7.0.3...v7.0.4">https://github.com/peter-evans/create-pull-request/compare/v7.0.3...v7.0.4</a></p> <h2>Create Pull Request v7.0.3</h2> <p>⚙️ Fixes an issue with commit signing where commit SHAs have variable lengths when abbreviated.</p> <h2>What's Changed</h2> <ul> <li>fix: disable abbreviated commit shas in diff by <a href="https://github.com/peter-evans"><code>@peter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3337">peter-evans/create-pull-request#3337</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-pull-request/compare/v7.0.2...v7.0.3">https://github.com/peter-evans/create-pull-request/compare/v7.0.2...v7.0.3</a></p> <h2>Create Pull Request v7.0.2</h2> <p>⚙️ Fixes an issue with commit signing when a change was detected as being a rename or copy.</p> <h2>What's Changed</h2> <ul> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.48 to 18.19.50 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3320">peter-evans/create-pull-request#3320</a></li> <li>build(deps-dev): bump typescript from 5.5.4 to 5.6.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3319">peter-evans/create-pull-request#3319</a></li> <li>fix: disable diff detection for renames and copies by <a href="https://github.com/peter-evans"><code>@peter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3330">peter-evans/create-pull-request#3330</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-pull-request/compare/v7.0.1...v7.0.2">https://github.com/peter-evans/create-pull-request/compare/v7.0.1...v7.0.2</a></p> <h2>Create Pull Request v7.0.1</h2> <p>⚙️ Fixes <a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3311">an issue</a> affecting one particular use case where the action fails on <code>diff --stat</code> with <code>fatal: ambiguous argument</code>.</p> <h2>What's Changed</h2> <ul> <li>build(deps): bump peter-evans/create-pull-request from 6 to 7 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3283">peter-evans/create-pull-request#3283</a></li> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.46 to 18.19.48 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3288">peter-evans/create-pull-request#3288</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 7.17.0 to 7.18.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/3289">peter-evans/create-pull-request#3289</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/peter-evans/create-pull-request/commit/5e914681df9dc83aa4e4905692ca88beb2f9e91f"><code>5e91468</code></a> fix: support symlinks when commit signing (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3359">#3359</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/2f38cd26bfebe301a5ee90bdd6550a69dc3ef23f"><code>2f38cd2</code></a> fix: support submodules when commit signing (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3354">#3354</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/7a8aeac749996aed943101d8e7dfb0cecc06197e"><code>7a8aeac</code></a> build(deps-dev): bump eslint from 8.57.0 to 8.57.1 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3344">#3344</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/d39d596a7720fc2c61c9aa5503097fb553431b5e"><code>d39d596</code></a> build(deps-dev): bump <code>@types/jest</code> from 29.5.12 to 29.5.13 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3343">#3343</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/f6f978fd3dc86c443f758f603d22dc554762c832"><code>f6f978f</code></a> docs: correct suggestion for bot setup (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3342">#3342</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/6cd32fd93684475c31847837f87bb135d40a2b79"><code>6cd32fd</code></a> fix: disable abbreviated commit shas in diff (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3337">#3337</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/d121e62763d8cc35b5fb1710e887d6e69a52d3a4"><code>d121e62</code></a> fix: disable diff detection for renames and copies (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3330">#3330</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/f4d66f4d5a5a7e65a185463192800c32d296ac6d"><code>f4d66f4</code></a> build(deps-dev): bump typescript from 5.5.4 to 5.6.2 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3319">#3319</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/488c869d17c8a5cb8a2f0a09471ed82c1d2a084f"><code>488c869</code></a> build(deps-dev): bump <code>@types/node</code> from 18.19.48 to 18.19.50 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/3320">#3320</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/5354f85616108575685a73a0ddd2f67c26a441c3"><code>5354f85</code></a> docs: update readme</li> <li>Additional commits viewable in <a href="https://github.com/peter-evans/create-pull-request/compare/c5a7806660adbe173f04e3e038b0ccdcd758773c...5e914681df9dc83aa4e4905692ca88beb2f9e91f">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=peter-evans/create-pull-request&package-manager=github_actions&previous-version=6.1.0&new-version=7.0.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Ref: codecov/test-results-action#91 The job randomly fails and causes CI failure.
billyvg
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lforst 😅
lforst
force-pushed
the
prepare-release/8.34.0
branch
from
October 10, 2024 14:13
bec4307
to
20914b0
Compare
Lms24
approved these changes
Oct 10, 2024
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.