WIP - Add firebase integration #13954
Open
+2,682
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Lms24
reviewed
Oct 14, 2024
There was a problem hiding this comment.
Took a first look. I think this PR is going into a good direction and I think - once we addressed the open todos - we should merge it in and build new features on top of it.
A couple of things I think are worth looking into in the future (i.e. not in this PR):
- should we patch
collection? I'm not entirely sure what the function does but it returns the ref to the document collection so maybe it's interesting? - I'd like us to collect more information about the query. Would be great if we could somehow build a query from the individual
querycomposition functions - I think it'd be worth to look into firebase auth and file storage but these could definitely come later.
packages/node/src/integrations/tracing/firebase/otel/patches/firestore.ts
Outdated
Show resolved
Hide resolved
Lms24
reviewed
Oct 15, 2024
packages/node/src/integrations/tracing/firebase/otel/patches/firestore.ts
Show resolved
Hide resolved
Lms24
reviewed
Oct 29, 2024
dev-packages/e2e-tests/test-applications/firebase/tests/transactions.test.ts
Outdated
Show resolved
Hide resolved
dev-packages/e2e-tests/test-applications/firebase/tests/transactions.test.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+106
to
+109
| expect(transactionEvent.spans![0]).toMatchObject(spanAddDoc); | ||
| expect(transactionEvent.spans![1]).toMatchObject(spanSetDocs); | ||
| expect(transactionEvent.spans![2]).toMatchObject(spanGetDocs); | ||
| expect(transactionEvent.spans![3]).toMatchObject(spanDeleteDoc); |
There was a problem hiding this comment.
If it turns out that this assertion becomes flaky on CI I think it's perfectly reasonable for us to ensure that all the spans are in the spans array but we don't need to rely on the specific order. We'll reconstruct the span tree in the UI anyway based on the parent/child relations and timestamps.
I think this might be flaky because I'm not sure if our Sentry<>Otel span serialization logic is order-preserving.
dev-packages/e2e-tests/test-applications/firebase/docker/firebase/firestore.rules
Outdated
Show resolved
Hide resolved
# Conflicts: # dev-packages/node-integration-tests/package.json # packages/node/src/index.ts # yarn.lock
lforst
reviewed
Oct 30, 2024
| deleteDoc, | ||
| getDocs, | ||
| setDoc, | ||
| } from '@firebase/firestore'; |
There was a problem hiding this comment.
Before we merge, let's make sure that this doesn't end up in the .d.ts in any way.
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).