Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nextjs): Add method and url to route handler request data #14084

Merged
merged 4 commits into from
Oct 29, 2024
Merged

feat(nextjs): Add method and url to route handler request data #14084

merged 4 commits into from
Oct 29, 2024

Conversation

onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Oct 28, 2024 •
edited
Loading

Resolves: #13908

@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
634 1 633 33
View the top 1 failed tests by shortest run time 
route-handlers.test.ts Should record exceptions and transactions for faulty route handlers
Stack Traces | 0.255s run time 
route-handlers.test.ts:35:5 Should record exceptions and transactions for faulty route handlers

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@onurtemizkan onurtemizkan force-pushed the onur/nextjs-route-handler-requestdata branch from 4cd8e8d to b7d1eed Compare October 29, 2024 08:59
@onurtemizkan onurtemizkan force-pushed the onur/nextjs-route-handler-requestdata branch from b7d1eed to 0659e96 Compare October 29, 2024 09:00
@onurtemizkan onurtemizkan marked this pull request as ready for review October 29, 2024 09:22
lforst
lforst reviewed Oct 29, 2024
View reviewed changes
dev-packages/e2e-tests/test-applications/nextjs-app-dir/tests/route-handlers.test.ts Outdated
@@ -60,6 +60,9 @@ test('Should record exceptions and transactions for faulty route handlers', asyn

expect(routehandlerError.exception?.values?.[0].value).toBe('route-handler-error');

expect(routehandlerError.request?.method).toBe('PUT');
expect(routehandlerError.request?.url).toContain('/route-handlers/[param]/error');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what we really need here is the unparameterized url. Which is a major pain in the butt to grab in Next.js because it turns static routes dynamic 🤔 Let me sit on this a bit.

@lforst lforst merged commit 06ef628 into develop Oct 29, 2024
146 checks passed
@lforst lforst deleted the onur/nextjs-route-handler-requestdata branch October 29, 2024 12:33
@github-actions github-actions bot mentioned this pull request Oct 31, 2024
Closed
3 tasks
alexandresoro pushed a commit to alexandresoro/ouca that referenced this pull request Nov 3, 2024
@alexandresoro
fix(deps): update sentry-javascript monorepo to v8.36.0 (minor) (#289)
32f92e3 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@sentry/node](https://github.com/getsentry/sentry-javascript/tree/master/packages/node) ([source](https://github.com/getsentry/sentry-javascript)) | dependencies | minor | [`8.35.0` -> `8.36.0`](https://renovatebot.com/diffs/npm/@sentry%2fnode/8.35.0/8.36.0) |
| [@sentry/react](https://github.com/getsentry/sentry-javascript/tree/master/packages/react) ([source](https://github.com/getsentry/sentry-javascript)) | dependencies | minor | [`8.35.0` -> `8.36.0`](https://renovatebot.com/diffs/npm/@sentry%2freact/8.35.0/8.36.0) |

---

### Release Notes

<details>
<summary>getsentry/sentry-javascript (@&#8203;sentry/node)</summary>

### [`v8.36.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8360)

[Compare Source](getsentry/sentry-javascript@8.35.0...8.36.0)

##### Important Changes

-   **feat(nextjs/vercel-edge/cloudflare): Switch to OTEL for performance monitoring ([#&#8203;13889](getsentry/sentry-javascript#13889

With this release, the Sentry Next.js, and Cloudflare SDKs will now capture performance data based on OpenTelemetry.
Some exceptions apply in cases where Next.js captures inaccurate data itself.

NOTE: You may experience minor differences in transaction names in Sentry.
Most importantly transactions for serverside pages router invocations will now be named `GET /[param]/my/route` instead of `/[param]/my/route`.
This means that those transactions are now better aligned with the OpenTelemetry semantic conventions.

##### Other Changes

-   deps: Bump bundler plugins and CLI to 2.22.6 and 2.37.0 respectively ([#&#8203;14050](getsentry/sentry-javascript#14050))
-   feat(deps): bump [@&#8203;opentelemetry/instrumentation-aws-sdk](https://github.com/opentelemetry/instrumentation-aws-sdk) from 0.44.0 to 0.45.0 ([#&#8203;14099](getsentry/sentry-javascript#14099))
-   feat(deps): bump [@&#8203;opentelemetry/instrumentation-connect](https://github.com/opentelemetry/instrumentation-connect) from 0.39.0 to 0.40.0 ([#&#8203;14101](getsentry/sentry-javascript#14101))
-   feat(deps): bump [@&#8203;opentelemetry/instrumentation-express](https://github.com/opentelemetry/instrumentation-express) from 0.43.0 to 0.44.0 ([#&#8203;14102](getsentry/sentry-javascript#14102))
-   feat(deps): bump [@&#8203;opentelemetry/instrumentation-fs](https://github.com/opentelemetry/instrumentation-fs) from 0.15.0 to 0.16.0 ([#&#8203;14098](getsentry/sentry-javascript#14098))
-   feat(deps): bump [@&#8203;opentelemetry/instrumentation-kafkajs](https://github.com/opentelemetry/instrumentation-kafkajs) from 0.3.0 to 0.4.0 ([#&#8203;14100](getsentry/sentry-javascript#14100))
-   feat(nextjs): Add method and url to route handler request data ([#&#8203;14084](getsentry/sentry-javascript#14084))
-   feat(node): Add breadcrumbs for `child_process` and `worker_thread` ([#&#8203;13896](getsentry/sentry-javascript#13896))
-   fix(core): Ensure standalone spans are not sent if SDK is disabled ([#&#8203;14088](getsentry/sentry-javascript#14088))
-   fix(nextjs): Await flush in api handlers ([#&#8203;14023](getsentry/sentry-javascript#14023))
-   fix(nextjs): Don't leak webpack types into exports ([#&#8203;14116](getsentry/sentry-javascript#14116))
-   fix(nextjs): Fix matching logic for file convention type for root level components ([#&#8203;14038](getsentry/sentry-javascript#14038))
-   fix(nextjs): Respect directives in value injection loader ([#&#8203;14083](getsentry/sentry-javascript#14083))
-   fix(nuxt): Only wrap `.mjs` entry files in rollup ([#&#8203;14060](getsentry/sentry-javascript#14060))
-   fix(nuxt): Re-export all exported bindings ([#&#8203;14086](getsentry/sentry-javascript#14086))
-   fix(nuxt): Server-side setup in readme ([#&#8203;14049](getsentry/sentry-javascript#14049))
-   fix(profiling-node): Always warn when running on incompatible major version of Node.js ([#&#8203;14043](getsentry/sentry-javascript#14043))
-   fix(replay): Fix `onError` callback ([#&#8203;14002](getsentry/sentry-javascript#14002))
-   perf(otel): Only calculate current timestamp once ([#&#8203;14094](getsentry/sentry-javascript#14094))
-   test(browser-integration): Add sentry DSN route handler by default ([#&#8203;14095](getsentry/sentry-javascript#14095))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMzguNiIsInVwZGF0ZWRJblZlciI6IjM4LjEzOC42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/289
Reviewed-by: Alexandre Soro <[email protected]>
Co-authored-by: renovate <[email protected]>
Co-committed-by: renovate <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

POST request handled as GET in nextjs route handlers
2 participants
@onurtemizkan @lforst