Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix flaky loader test #14092

Closed
wants to merge 1 commit into from
Closed

test: Fix flaky loader test #14092

wants to merge 1 commit into from

Conversation

mydea
Copy link
Member

@mydea mydea commented Oct 28, 2024

@mydea mydea self-assigned this Oct 28, 2024
chargome
chargome approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure though why this is just added on some tests 🤔

@mydea
Copy link
Member Author

mydea commented Oct 28, 2024

Yeah we may also think about adding this by default I guess 🤔 I guess there are few cases where we do not want this, and in these we may as well overwrite this and return something faulty I'd say. I'll try this!

@mydea
Copy link
Member Author

mydea commented Oct 29, 2024

Closing in favor of #14095

@mydea mydea closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chargome chargome chargome approved these changes

@andreiborza andreiborza Awaiting requested review from andreiborza

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @chargome