Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): Add SolidStart spa mode test app #14127

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

andreiborza
Copy link
Member

While working on the plugin to auto instrument the server I noticed that running SolidStart in spa mode (ssr: false) behaved slightly differently so I added a test app for this.

});
};

export default function ServerErrorPage() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this relevant then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, no it isn't!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a double take and the getPrefecture function is extracted as a server function and then just executed as an api call on this run so I think it's fine to leave this in as is.

@andreiborza andreiborza merged commit 0d290a0 into develop Oct 30, 2024
151 checks passed
@andreiborza andreiborza deleted the ab/solidstart-e2e-spa-test-app branch October 30, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants