feat(flags): add launch darkly integration #14130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| walk(filePath); | ||
| } else { | ||
| if (filePath.endsWith('.d.ts')) { | ||
| const content = fs.readFileSync(filePath, 'utf8'); |
Check failure
Code scanning / CodeQL
Potential file system race condition High
| const newContent = content.replace(preactImportRegex, '// replaced import from preact'); | ||
|
|
||
| // and write the new content to the file | ||
| fs.writeFileSync(filePath, snippet + newContent, 'utf8'); |
Check failure
Code scanning / CodeQL
Potential file system race condition High
aliu39
commented
Oct 29, 2024
size-limit report 📦
|
michellewzhang
force-pushed
the
aliu/launch-darkly
branch
from
a815c13
to
79e5b24
Compare
cmanallen
requested changes
Oct 31, 2024
cmanallen
requested changes
Oct 31, 2024
billyvg
reviewed
Oct 31, 2024
aliu39
force-pushed
the
aliu/launch-darkly
branch
from
f494720
to
bd04755
Compare
|
Notion doc by @cmanallen , summarizing constraints and potential approaches: https://www.notion.so/sentry/Feature-Flags-JavaScript-SDK-1358b10e4b5d805288abe1a4fede75ed?pvs=4 For now I'm cloning the current branch (approach 3), then going ahead with approach 1. |
❌ 4 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).