-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flags): Add LaunchDarkly integration #14207
base: develop
Are you sure you want to change the base?
Conversation
…try-javascript into aliu/launch-darkly
…try-javascript into aliu/launch-darkly
…ag field and methods
/** | ||
* Sentry integration for capturing feature flags from LaunchDarkly. | ||
* | ||
* See the [feature flag documentation](https://develop.sentry.dev/sdk/expected-features/#feature-flags) for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Section added by getsentry/sentry-docs#11746
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Will this also work for |
No, because the LDInspectionFlagUsedHandler interface is not available for server side JS. This will work for the other client sdks though (react, node-client) |
Ah to bad, we were hoping we could use it with Next.js, but best practice is to use a combination of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aside from the nits, looks pretty good to me
Notion doc summarizing our goal, constraints, and potential approaches: https://www.notion.so/sentry/Feature-Flags-JavaScript-SDK-1358b10e4b5d805288abe1a4fede75ed?pvs=4. This PR implements approach 1.
Ref