ref(profiling) Fix electron crash #14216
Open
+96
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasBa
force-pushed
the
jb/profiling/electron-binaries
branch
from
ed3d79d
to
c82add5
Compare
JonasBa
commented
Nov 8, 2024
| profile_title, | ||
| {v8::CpuProfilingMode::kCallerLineNumbers, | ||
| v8::CpuProfilingOptions::kNoSampleLimit, kSamplingInterval}); | ||
| profile_title, v8::CpuProfilingMode::kCallerLineNumbers, true, |
There was a problem hiding this comment.
Unclear why using the options signature causes this to sigabrt, but this will do too.
size-limit report 📦
|
timfish
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
I haven't checked to see exactly what causes this but Electron applies a load of patches to v8/node which might cause something like this 🤔
Hah, good to know! My knowledge of electron isn't great, but that gives me a lead to look at next, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the electron crash observed in #13978
I am not entirely sure as to why this causes a sigabrt, so I am working around the issue (obtaining a coredump out of electron did not seem trivial and my knowledge around electron isn't very extensive). The v8 options class and the constants are exposed correctly, I ruled that out, however the crash still seems to happen when they are used in this specific signature.
In order to have this running with electron, users will require to use the electron/rebuild package, which is the recommended approach by electron that rebuilds native node addons by providing the correct abi headers for the electron version the user is running. For now, we wont provide any prebuilt binaries and instead rely on the fallback mechanism to load the correct module. I will reevaluate this if it causes issues with bundling and look to add proper runtime electron detection.