Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(google-cloud-serverless): Update homepage link in package.json #14411

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

robinvw1
Copy link
Contributor

The link to the homepage results in a 404.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @robinvw1, Thank you!

Just as a heads-up: I changed the PR target branch to develop because we use a gitflow-like approach and merge things first into develop.

@Lms24 Lms24 changed the base branch from master to develop November 21, 2024 16:37
@robinvw1 robinvw1 force-pushed the patch-1 branch 2 times, most recently from 3a6fb74 to ec9126e Compare November 22, 2024 09:32
@robinvw1 robinvw1 requested review from a team as code owners November 22, 2024 09:32
@AbhiPrasad AbhiPrasad merged commit aa92eef into getsentry:develop Dec 10, 2024
33 checks passed
AbhiPrasad added a commit that referenced this pull request Dec 10, 2024
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #14411

Co-authored-by: AbhiPrasad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants