Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(browser-utils): Update web-vitals to v4.2.4 #14439

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 22, 2024

Let's see what this breaks :D

Updates the vendored web-vitals library from 3.5.2 to 4.2.4
I haven't seen any changes of major concern for us but I think it makes a lot of sense to stay up to date. Especially considering that they seem to be working on a version 5.x already.

Some noteable changes:

  • breaking type changes (version 4.0.0)
  • INP fixes and code refactors
  • minor LCP fix for web vitals library being late-initialized. I don't think this applies to us but who knows...

@Lms24 Lms24 self-assigned this Nov 22, 2024
Copy link
Contributor

github-actions bot commented Nov 22, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.01 KB - -
@sentry/browser - with treeshaking flags 21.72 KB - -
⛔️ @sentry/browser (incl. Tracing) (max: 35.64 KB) 35.73 KB +0.31% +113 B 🔺
@sentry/browser (incl. Tracing, Replay) 72.52 KB +0.15% +110 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.8 KB +0.17% +105 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 76.82 KB +0.14% +105 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 89.29 KB +0.13% +117 B 🔺
@sentry/browser (incl. Feedback) 39.75 KB - -
@sentry/browser (incl. sendFeedback) 27.64 KB - -
@sentry/browser (incl. FeedbackAsync) 32.43 KB - -
@sentry/react 25.71 KB - -
@sentry/react (incl. Tracing) 38.57 KB +0.22% +84 B 🔺
@sentry/vue 27.21 KB - -
@sentry/vue (incl. Tracing) 37.54 KB +0.26% +96 B 🔺
@sentry/svelte 23.18 KB - -
CDN Bundle 24.18 KB - -
CDN Bundle (incl. Tracing) 37.3 KB +0.3% +112 B 🔺
CDN Bundle (incl. Tracing, Replay) 72.06 KB +0.14% +99 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 77.42 KB +0.15% +112 B 🔺
CDN Bundle - uncompressed 71.15 KB - -
CDN Bundle (incl. Tracing) - uncompressed 111.1 KB +0.53% +591 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 223.9 KB +0.26% +591 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 237.12 KB +0.25% +591 B 🔺
@sentry/nextjs (client) 38.67 KB +0.22% +86 B 🔺
⛔️ @sentry/sveltekit (client) (max: 36.13 KB) 36.22 KB +0.25% +90 B 🔺
@sentry/node 134.63 KB - -
@sentry/node - without tracing 96.47 KB - -
@sentry/aws-serverless 106.7 KB - -

View base workflow run

Copy link

codecov bot commented Nov 22, 2024

❌ 17 Tests Failed:

Tests completed Failed Passed Skipped
463 17 446 146
View the top 3 failed tests by shortest run time
transactions.test.ts sends an INP span
Stack Traces | 30s run time
transactions.test.ts:58:5 sends an INP span
client-inp.test.ts sends an INP span during pageload
Stack Traces | 30s run time
client-inp.test.ts:4:5 sends an INP span during pageload
tracing/metrics/web-vitals-inp-late/test.ts should capture an INP click event span after pageload
Stack Traces | 30s run time
test.ts:12:11 should capture an INP click event span after pageload

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

Comment on lines -35 to -37
// Used to store the interaction count after a bfcache restore, since p98
// interaction latencies should only consider the current navigation.
const prevInteractionCount = 0;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was extracted to the /lib/interaction.ts file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant