Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: Initial v9 changes #14636

Merged
merged 8 commits into from
Dec 13, 2024
Merged

meta: Initial v9 changes #14636

merged 8 commits into from
Dec 13, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Dec 10, 2024

This PR contains all commits for v9 before we cut a v8 branch and continue work on v9 on develop.

🚨 MAKE SURE TO REBASE MERGE THIS PR

Copy link
Contributor

github-actions bot commented Dec 10, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.29 KB - -
@sentry/browser - with treeshaking flags 21.96 KB - -
@sentry/browser (incl. Tracing) 35.79 KB - -
@sentry/browser (incl. Tracing, Replay) 73.03 KB +0.03% +19 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.41 KB +0.01% +3 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 77.45 KB +0.17% +127 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 89.83 KB +0.03% +20 B 🔺
@sentry/browser (incl. Feedback) 40.04 KB - -
@sentry/browser (incl. sendFeedback) 27.89 KB - -
@sentry/browser (incl. FeedbackAsync) 32.68 KB - -
@sentry/react 25.96 KB - -
@sentry/react (incl. Tracing) 38.6 KB - -
@sentry/vue 27.49 KB -0.03% -6 B 🔽
@sentry/vue (incl. Tracing) 37.62 KB -0.02% -4 B 🔽
@sentry/svelte 23.45 KB - -
CDN Bundle 24.43 KB - -
CDN Bundle (incl. Tracing) 37.46 KB - -
CDN Bundle (incl. Tracing, Replay) 72.55 KB -0.13% -95 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 77.94 KB -0.1% -76 B 🔽
CDN Bundle - uncompressed 71.74 KB - -
CDN Bundle (incl. Tracing) - uncompressed 111.05 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 225.1 KB -0.01% -6 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 238.31 KB -0.01% -6 B 🔽
@sentry/nextjs (client) 38.87 KB -0.03% -11 B 🔽
@sentry/sveltekit (client) 36.29 KB - -
@sentry/node 162.75 KB +0.15% +240 B 🔺
@sentry/node - without tracing 98.89 KB +0.19% +184 B 🔺
@sentry/aws-serverless 126.63 KB +0.2% +251 B 🔺

View base workflow run

@mydea mydea force-pushed the v9 branch 2 times, most recently from 1c9544b to 7bf602c Compare December 13, 2024 11:51
@lforst lforst marked this pull request as ready for review December 13, 2024 12:37
mydea and others added 7 commits December 13, 2024 13:37
In order for us to have size-limit comparison etc, we need to ensure CI
runs on v8 & v9 branches too.
With this PR, the default value for the `spans` option in the
`httpIntegration` is changed to `false`, if `skipOpenTelemetrySetup:
true` is configured. This is what you'd expect as a user, you do not
want Sentry to register any OTEL instrumentation and emit any spans in
this scenario.

Closes #14675
@lforst lforst requested review from mydea, Lms24 and AbhiPrasad December 13, 2024 14:55
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@lforst lforst merged commit e0a1e7a into develop Dec 13, 2024
366 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants