Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): Inline nitro-utils function #14680

Merged
merged 7 commits into from
Dec 12, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
generate files if not existent
s1gr1d committed Dec 12, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit c7095a44269e7fb2db32b6944a49135045a45481
4 changes: 1 addition & 3 deletions packages/nuxt/build.config.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import { defineBuildConfig } from 'unbuild';

// Build Config for the Nuxt Module Builder: https://github.com/nuxt/module-builder
export default defineBuildConfig({
failOnWarn: false,
});
export default defineBuildConfig({});
19 changes: 19 additions & 0 deletions packages/nuxt/generate-build-stubs.bash
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# The Nuxt package is built in 2 steps and the nuxt-module-builder shows a warning if one of the files specified in the package.json is missing.
# unbuild checks for this: https://github.com/unjs/unbuild/blob/8c647ec005a02f852e56aeef6076a35eede17df1/src/validate.ts#L81

# The runtime folder (which is built with the nuxt-module-builder) is separate from the rest of the package and therefore we can ignore those warnings
# as those files are generated in the other build step.

# Create the directories if they do not exist
mkdir -p build/cjs
mkdir -p build/esm
mkdir -p build/types

# Write files if they do not exist
[ ! -f build/cjs/index.server.js ] && echo "module.exports = {}" > build/cjs/index.server.js
[ ! -f build/cjs/index.client.js ] && echo "module.exports = {}" > build/cjs/index.client.js
[ ! -f build/esm/index.server.js ] && echo "export {}" > build/esm/index.server.js
[ ! -f build/esm/index.client.js ] && echo "export {}" > build/esm/index.client.js
[ ! -f build/types/index.types.d.ts ] && echo "export {}" > build/types/index.types.d.ts

echo "Created build stubs for missing files"
2 changes: 1 addition & 1 deletion packages/nuxt/package.json
Original file line number Diff line number Diff line change
@@ -58,7 +58,7 @@
"scripts": {
"build": "run-s build:types build:transpile",
"build:dev": "yarn build",
"build:nuxt-module": "nuxt-module-build build --outDir build/module",
"build:nuxt-module": "bash ./generate-build-stubs.bash && nuxt-module-build build --outDir build/module",
"build:transpile": "rollup -c rollup.npm.config.mjs && yarn build:nuxt-module",
"build:types": "tsc -p tsconfig.types.json",
"build:watch": "run-p build:transpile:watch build:types:watch",