Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(flags): remove OpenFeatureHook from exports and setup code #14838

Open
wants to merge 5 commits into
base: v8
Choose a base branch
from

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Dec 23, 2024

Closes #14645

By un-exporting the Hook, this will simplify setup for users.

The decision to track a single client is something we're doing across all FF integrations. From getsentry/sentry-python#3895:

All provider SDKs so far have the concept of a "client" class, which is used to connect to the server and query flags. Since clients can query multiple projects/environments by specifying a context, it seems rare for an app to use >1 client.
I discussed with @billyvg and we want to stay consistent for all FF integrations, and support flag tracking for only one client, until we get requests for more. Therefore, users should be required to pass a client to the Integration. We'll register hooks on that client, rather than globally.

Updated setup code can be seen at: https://github.com/getsentry/sentry-docs/pull/12222/files
Todo:

  • update docstr

@aliu39 aliu39 changed the title ref(flags): abstract OpenFeatureHook away from setup and track a single OpenFeatureClient ref(flags): remove OpenFeatureHook from exports/setup code Dec 27, 2024
@aliu39 aliu39 changed the title ref(flags): remove OpenFeatureHook from exports/setup code ref(flags): remove OpenFeatureHook from exports and setup code Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant