Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Review copy/formatting for migration docs #15178

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

AbhiPrasad
Copy link
Member

Some more formatting changes to the migration docs, also remove todos where appropriate.

ref #14289

@AbhiPrasad AbhiPrasad requested a review from a team January 27, 2025 16:57
@AbhiPrasad AbhiPrasad self-assigned this Jan 27, 2025
@AbhiPrasad AbhiPrasad requested review from lforst and Lms24 and removed request for a team January 27, 2025 16:57
@@ -128,7 +126,7 @@ Older Typescript versions _may_ still work, but we will not test them anymore an

The passed instrumentation instance will override the default instrumentation instance the integration would use, while the `prismaIntegration` will still ensure data compatibility for the various Prisma versions.

1. Depending on your Prisma version (prior to Prisma version 6), add `previewFeatures = ["tracing"]` to the client generator block of your Prisma schema:
3. Depending on your Prisma version (prior to Prisma version 6), add `previewFeatures = ["tracing"]` to the client generator block of your Prisma schema:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was intentional because it is rendered in markdown correctly and it is very annoying having to update all of the numbers when you update something in the middle.

docs/migration/v8-to-v9.md Outdated Show resolved Hide resolved
docs/migration/v8-to-v9.md Outdated Show resolved Hide resolved
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) January 29, 2025 14:29
@AbhiPrasad AbhiPrasad merged commit 9ce4ad1 into develop Jan 29, 2025
26 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-jan-2025-migration-cleanup branch January 29, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants