Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): Add experimental option to record cross origin iframes #15421

Closed

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Feb 14, 2025

This allows users to record cross origin iframes by enabling the experimental option: _experiments.recordCrossOriginIframe

This allows users to record cross origin iframes by enabling the experimental option: `_experiments.recordCrossOriginIframe`
Copy link
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 22.95 KB - -
@sentry/browser - with treeshaking flags 22.73 KB - -
@sentry/browser (incl. Tracing) 35.89 KB - -
@sentry/browser (incl. Tracing, Replay) 72.91 KB +0.04% +28 B 🔺
⛔️ @sentry/browser (incl. Tracing, Replay) - with treeshaking flags (max: 66.41 KB) 66.41 KB +0.04% +22 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 77.16 KB +0.04% +27 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 90.12 KB +0.03% +25 B 🔺
@sentry/browser (incl. Feedback) 40.1 KB - -
@sentry/browser (incl. sendFeedback) 27.58 KB - -
@sentry/browser (incl. FeedbackAsync) 32.38 KB - -
@sentry/react 24.78 KB - -
@sentry/react (incl. Tracing) 37.78 KB - -
@sentry/vue 27.14 KB - -
@sentry/vue (incl. Tracing) 37.6 KB - -
@sentry/svelte 22.99 KB - -
CDN Bundle 24.17 KB - -
CDN Bundle (incl. Tracing) 35.93 KB - -
CDN Bundle (incl. Tracing, Replay) 70.77 KB +0.03% +18 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 75.93 KB +0.03% +17 B 🔺
CDN Bundle - uncompressed 70.64 KB - -
CDN Bundle (incl. Tracing) - uncompressed 106.74 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.01 KB +0.03% +61 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 230.58 KB +0.03% +61 B 🔺
@sentry/nextjs (client) 38.76 KB - -
@sentry/sveltekit (client) 36.32 KB - -
@sentry/node 127.6 KB - -
@sentry/node - without tracing 97.9 KB - -
@sentry/aws-serverless 107.34 KB - -

View base workflow run

Copy link

codecov bot commented Feb 14, 2025

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
2296 4 2292 303
View the top 3 failed test(s) by shortest run time
test/integration/test/client/root-loader.test.ts should throw redirect to an external path with no baggage and trace injected.
Stack Traces | 0.092s run time
root-loader.test.ts:177:1 should throw redirect to an external path with no baggage and trace injected.
test/integration/rrweb.test.ts > Integration | rrweb > calls rrweb.record with updated sampling options on iOS
Stack Traces | 0.134s run time
Error: Snapshot `Integration | rrweb > calls rrweb.record with updated sampling options on iOS 1` mismatched

- Expected
+ Received

@@ -14,10 +14,11 @@
      "password": true,
    },
    "maskTextFn": undefined,
    "maskTextSelector": ".sentry-mask,[data-sentry-mask]",
    "onMutation": [Function],
+   "recordCrossOriginIframes": false,
    "sampling": {
      "mousemove": false,
    },
    "slimDOMOptions": "all",
    "unblockSelector": "",

test/integration/rrweb.test.ts:115:43
test/integration/rrweb.test.ts > Integration | rrweb > calls rrweb.record with checkoutEveryNms
Stack Traces | 0.158s run time
Error: Snapshot `Integration | rrweb > calls rrweb.record with checkoutEveryNms 1` mismatched

- Expected
+ Received

@@ -15,9 +15,10 @@
      "password": true,
    },
    "maskTextFn": undefined,
    "maskTextSelector": ".sentry-mask,[data-sentry-mask]",
    "onMutation": [Function],
+   "recordCrossOriginIframes": false,
    "slimDOMOptions": "all",
    "unblockSelector": "",
    "unmaskTextSelector": "",
  }

test/integration/rrweb.test.ts:63:43

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@billyvg
Copy link
Member Author

billyvg commented Feb 14, 2025

Dupe of #14916

@billyvg billyvg closed this Feb 14, 2025
@billyvg billyvg deleted the feat-replay-allow-cross-origin-iframe-recording branch February 14, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant