Skip to content

fix(browser): Ensure explicit parentSpan is considered #16776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented Jun 30, 2025

Even if parentSpanIsAlwaysRootSpan=true is configured.

Fixes #16769

@mydea mydea requested review from s1gr1d and andreiborza June 30, 2025 14:29
@mydea mydea self-assigned this Jun 30, 2025
Copy link
Contributor

github-actions bot commented Jun 30, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.99 kB - -
@sentry/browser - with treeshaking flags 23.76 kB - -
@sentry/browser (incl. Tracing) 39.04 kB +0.05% +16 B 🔺
@sentry/browser (incl. Tracing, Replay) 77.17 kB +0.02% +13 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 70.26 kB +0.02% +11 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 81.94 kB +0.02% +13 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 94.03 kB +0.02% +17 B 🔺
@sentry/browser (incl. Feedback) 40.75 kB - -
@sentry/browser (incl. sendFeedback) 28.7 kB - -
@sentry/browser (incl. FeedbackAsync) 33.59 kB - -
@sentry/react 25.76 kB - -
@sentry/react (incl. Tracing) 41 kB +0.02% +6 B 🔺
@sentry/vue 28.37 kB +0.06% +16 B 🔺
@sentry/vue (incl. Tracing) 40.87 kB +0.03% +9 B 🔺
@sentry/svelte 24.01 kB - -
CDN Bundle 25.5 kB - -
CDN Bundle (incl. Tracing) 39.12 kB +0.04% +14 B 🔺
CDN Bundle (incl. Tracing, Replay) 75.02 kB +0.03% +18 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 80.47 kB +0.02% +12 B 🔺
CDN Bundle - uncompressed 74.5 kB - -
CDN Bundle (incl. Tracing) - uncompressed 116.67 kB +0.04% +41 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 230.72 kB +0.02% +41 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 243.54 kB +0.02% +41 B 🔺
@sentry/nextjs (client) 42.64 kB +0.02% +7 B 🔺
@sentry/sveltekit (client) 39.51 kB +0.05% +17 B 🔺
@sentry/node 154.31 kB +0.02% +16 B 🔺
@sentry/node - without tracing 98.63 kB -0.01% -1 B 🔽
@sentry/aws-serverless 124.4 kB - -

View base workflow run

Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked if we already document this behavior in JSDoc so it's clear to users what happens when they set null - and it's already documented 👍

Even if `parentSpanIsAlwaysRootSpan=true` is configured.
@mydea mydea force-pushed the fn/browser-explicit-parentSpan branch from 8099707 to 3a2a722 Compare July 1, 2025 08:36
Copy link

cursor bot commented Jul 1, 2025

🚨 BugBot couldn't run

BugBot is experiencing high demand right now. Try again in a few minutes by commenting "bugbot run" (requestId: serverGenReqId_d9b9eeb0-9ce9-4700-ae80-e5ce272f61ab).

Copy link

cursor bot commented Jul 1, 2025

🚨 BugBot couldn't run

BugBot is experiencing high demand right now. Try again in a few minutes by commenting "bugbot run" (requestId: serverGenReqId_85720651-6509-4f5a-b235-fa6efa9bbabe).

@mydea mydea merged commit cbc5acb into develop Jul 1, 2025
165 of 166 checks passed
@mydea mydea deleted the fn/browser-explicit-parentSpan branch July 1, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parentSpanIsAlwaysRootSpan disables options.parentSpan
3 participants