-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(browser): Ensure explicit parentSpan
is considered
#16776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked if we already document this behavior in JSDoc so it's clear to users what happens when they set null
- and it's already documented 👍
Even if `parentSpanIsAlwaysRootSpan=true` is configured.
8099707
to
3a2a722
Compare
🚨 BugBot couldn't runBugBot is experiencing high demand right now. Try again in a few minutes by commenting "bugbot run" (requestId: serverGenReqId_d9b9eeb0-9ce9-4700-ae80-e5ce272f61ab). |
🚨 BugBot couldn't runBugBot is experiencing high demand right now. Try again in a few minutes by commenting "bugbot run" (requestId: serverGenReqId_85720651-6509-4f5a-b235-fa6efa9bbabe). |
Even if
parentSpanIsAlwaysRootSpan=true
is configured.Fixes #16769