-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ci(v7): Bump to ubuntu-24.04 #17083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(v7): Bump to ubuntu-24.04 #17083
Conversation
size-limit report 📦
|
This reverts commit 4984514.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Playwright Tests Fail Due to Missing Dependencies
Playwright tests are failing on Ubuntu 24.04 runners in job_nextjs_integration_test
, job_browser_playwright_tests
, and job_browser_loader_tests
. This is because the npx playwright install --with-deps
flag and the npx playwright install-deps
step were removed from these jobs. Although OS dependencies are installed in job_install_deps
, each GitHub Actions job runs on a fresh runner, preventing these dependencies from being available to the separate Playwright test jobs.
.github/workflows/build.yml#L614-L620
sentry-javascript/.github/workflows/build.yml
Lines 614 to 620 in 5e1e26b
key: ${{ runner.os }}-Playwright-${{steps.playwright-version.outputs.version}} | |
- name: Install Playwright browser if not cached | |
if: steps.playwright-cache.outputs.cache-hit != 'true' && matrix.node >= 14 | |
run: npx playwright install | |
env: | |
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}} | |
- name: Run tests |
.github/workflows/build.yml#L706-L710
sentry-javascript/.github/workflows/build.yml
Lines 706 to 710 in 5e1e26b
- name: Install Playwright browser if not cached | |
if: steps.playwright-cache.outputs.cache-hit != 'true' | |
run: npx playwright install | |
env: | |
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}} |
.github/workflows/build.yml#L759-L763
sentry-javascript/.github/workflows/build.yml
Lines 759 to 763 in 5e1e26b
- name: Install Playwright browser if not cached | |
if: steps.playwright-cache.outputs.cache-hit != 'true' | |
run: npx playwright install | |
env: | |
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}} |
Bug: Missing Directory Causes Build Script Failure
The build:copy-bindings
script attempts to copy from compiled-bindings/
to lib/
. However, the node-gyp
build steps (and associated CI job) that previously created and populated compiled-bindings/
have been removed. This results in the compiled-bindings/
directory not existing, causing the cp
command to fail and break the build process.
packages/profiling-node/package.json#L53-L54
sentry-javascript/packages/profiling-node/package.json
Lines 53 to 54 in 5e1e26b
"build:types:watch": "tsc -p tsconfig.types.json --watch", | |
"build:copy-bindings": "cp -r compiled-bindings/ lib/", |
Was this report helpful? Give feedback by reacting with 👍 or 👎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Playwright Browser Installation Script Removed
The postinstall
script, which automatically installed Playwright browsers via yarn install-browsers
, was removed. This causes browser integration tests to fail due to missing browsers unless they are manually installed.
dev-packages/browser-integration-tests/package.json#L14-L16
sentry-javascript/dev-packages/browser-integration-tests/package.json
Lines 14 to 16 in 353f1ef
"fix": "eslint . --format stylish --fix", | |
"type-check": "tsc", | |
"pretest": "yarn clean && yarn type-check", |
job_nextjs_integration_test: | ||
name: Nextjs (Node ${{ matrix.node }}) Tests | ||
needs: [job_get_metadata, job_build] | ||
if: needs.job_get_metadata.outputs.changed_nextjs == 'true' || github.event_name != 'pull_request' | ||
if: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Next.js Integration Tests Disabled
The job_nextjs_integration_test
is completely disabled by setting its if
condition to false
. This likely accidental change prevents important Next.js integration tests from running, potentially masking functionality issues, especially after the upgrade to Ubuntu 24.04.
Locations (1)
"test:bundle": "node test-binaries.esbuild.js", | ||
"test": "cross-env SENTRY_PROFILER_BINARY_DIR=lib jest --config jest.config.js" | ||
"test:watch": "cross-env SENTRY_PROFILER_BINARY_DIR=compiled-bindings jest --watch", | ||
"test": "cross-env SENTRY_PROFILER_BINARY_DIR=compiled-bindings jest --config jest.config.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Node Profiling Build Fails Due to Missing Bindings
The packages/profiling-node
build and test scripts now rely on a compiled-bindings
directory that is never created or populated. The build:copy-bindings
script attempts to copy from this non-existent directory, leading to build failures. Similarly, test scripts set SENTRY_PROFILER_BINARY_DIR
to this missing directory, preventing tests from running. This change removed the previous node-gyp
steps responsible for generating these bindings.
Locations (1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing Postinstall Script Causes Test Failures
The postinstall
script, "yarn install-browsers"
, was removed from dev-packages/browser-integration-tests/package.json
. This script automatically installed Playwright browsers. Its removal prevents automatic browser installation during dependency setup, leading to browser integration test failures for local developers.
dev-packages/browser-integration-tests/package.json#L14-L15
sentry-javascript/dev-packages/browser-integration-tests/package.json
Lines 14 to 15 in 3e6a498
"fix": "eslint . --format stylish --fix", | |
"type-check": "tsc", |
ubuntu-20.04 is no longer working, so CI is no longer working and nothing can be merged in v7 :O
Changes required to make this work: