fix(core): Instrument invoke_agent root span, and support Vercel ai v5
#17395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RulaKhaled
changed the title
size-limit report 📦
|
RulaKhaled
force-pushed
the
first-round-v5
branch
from
fd2fb4c to
7d41fa7
Compare
RulaKhaled
changed the title
ai v5
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
RulaKhaled
changed the title
ai v5 ai v5
s1gr1d
reviewed
Aug 14, 2025
| @@ -118,6 +118,7 @@ export type { ReportDialogOptions } from './report-dialog'; | |||
| export { _INTERNAL_captureLog, _INTERNAL_flushLogsBuffer, _INTERNAL_captureSerializedLog } from './logs/exports'; | |||
| export { consoleLoggingIntegration } from './logs/console-integration'; | |||
| export { addVercelAiProcessors } from './utils/vercel-ai'; | |||
| export { getSpanForToolCallId, cleanupToolCallSpan } from './utils/vercel-ai/utils'; | |||
There was a problem hiding this comment.
Do we want this to be public API?
Comment on lines
+63
to
+72
| export function getSpanForToolCallId(toolCallId: string): Span | undefined { | ||
| return toolCallSpanMap.get(toolCallId); | ||
| } | ||
|
|
||
| /** | ||
| * Clean up the span mapping for a tool call ID | ||
| */ | ||
| export function cleanupToolCallSpan(toolCallId: string): void { | ||
| toolCallSpanMap.delete(toolCallId); | ||
| } |
There was a problem hiding this comment.
If we don't need to export this for users, we could also just inline this :)
Comment on lines
+103
to
+104
| scope.setTag('vercel.ai.tool.span.id', spanContext.spanId); | ||
| scope.setTag('vercel.ai.tool.trace.id', spanContext.traceId); |
There was a problem hiding this comment.
I think we could use span_id and trace_id here. And is there a specific reason we use tags on the scope here instead of attributes on the span? Just wondering 🤔
Suggested change
| scope.setTag('vercel.ai.tool.span.id', spanContext.spanId); | |
| scope.setTag('vercel.ai.tool.trace.id', spanContext.traceId); | |
| scope.setTag('vercel.ai.tool.spanId', spanContext.span_id); | |
| scope.setTag('vercel.ai.tool.traceId', spanContext.trace_id); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes are:
invoke_agentspan: This addresses that transaction event.spans only includes child spans, ensuring proper correlation beyond just children.vercelaiintegration layout in core: Restructured the vercelai folder to mirror our other AI agent integrations (split constants/utils/index) for clarity and easier maintenance.