Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(tracing): Unify DSC key names in envelope and baggage headers #5302

Merged
merged 3 commits into from
Jun 24, 2022

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jun 23, 2022

This PR unifies the key names in the envelope trace header and the baggage http header. As a result, we get rid of the mapping that was necessary before, thereby loosing a little JS bundle weight ;)
Furthermore, the PR renames the EventTraceContext interface and aligns the Baggage type definition so that we can ensure that both DSC transport mechanisms are based on the same keys.

Since EventTraceContext was exported before and therefore publicly accesible, I left the export as an alias of DynamicSamplingContext. If this is approved, I'll add that export to (#5194).
(Happy to discuss and adjust any of the changes)

fixes #5301

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.3 KB (added)
@sentry/browser - ES5 CDN Bundle (minified) 59.73 KB (added)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.11 KB (added)
@sentry/browser - ES6 CDN Bundle (minified) 53.37 KB (added)
@sentry/browser - Webpack (gzipped + minified) 19.89 KB (added)
@sentry/browser - Webpack (minified) 64.81 KB (added)
@sentry/react - Webpack (gzipped + minified) 19.92 KB (added)
@sentry/nextjs Client - Webpack (gzipped + minified) 44.07 KB (added)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.66 KB (added)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.12 KB (added)

@Lms24 Lms24 requested review from AbhiPrasad and lforst June 23, 2022 16:25
@Lms24 Lms24 marked this pull request as ready for review June 23, 2022 16:26
@Lms24 Lms24 self-assigned this Jun 23, 2022
@Lms24 Lms24 added this to the Dynamic Sampling milestone Jun 23, 2022
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way cleaner!

packages/types/src/index.ts Outdated Show resolved Hide resolved
packages/tracing/src/transaction.ts Outdated Show resolved Hide resolved
packages/tracing/src/transaction.ts Outdated Show resolved Hide resolved
@Lms24 Lms24 merged commit b9f2122 into master Jun 24, 2022
@Lms24 Lms24 deleted the lms-dsc-unify-baggage-env branch June 24, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DSC] Unify baggage and envelope header structure
2 participants