Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nextjs): Remove obsolete dataFetchers loader #5713

Merged
merged 3 commits into from
Sep 9, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/nextjs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"access": "public"
},
"dependencies": {
"@babel/parser": "^7.18.10",
"@rollup/plugin-sucrase": "4.0.4",
"@sentry/core": "7.12.1",
"@sentry/hub": "7.12.1",
Expand All @@ -29,14 +28,11 @@
"@sentry/utils": "7.12.1",
"@sentry/webpack-plugin": "1.19.0",
"chalk": "3.0.0",
"jscodeshift": "^0.13.1",
"rollup": "2.78.0",
"tslib": "^1.9.3"
},
"devDependencies": {
"@babel/types": "7.18.10",
"@sentry/nextjs": "7.12.1",
"@types/jscodeshift": "^0.11.5",
"@types/webpack": "^4.41.31",
"next": "10.1.3"
},
Expand Down
12 changes: 5 additions & 7 deletions packages/nextjs/rollup.npm.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,12 @@ export default [
),
...makeNPMConfigVariants(
makeBaseNPMConfig({
entrypoints: [
'src/config/templates/prefixLoaderTemplate.ts',
'src/config/templates/proxyLoaderTemplate.ts',
'src/config/templates/dataFetchersLoaderTemplate.ts',
],
entrypoints: ['src/config/templates/prefixLoaderTemplate.ts', 'src/config/templates/proxyLoaderTemplate.ts'],

packageSpecificConfig: {
plugins: [plugins.makeRemoveMultiLineCommentsPlugin()],
output: {
// Preserve the original file structure (i.e., so that everything is still relative to `src`). (Not entirely
// clear why this is necessary here and not for other entrypoints in this file.)
// Preserve the original file structure (i.e., so that everything is still relative to `src`)
entryFileNames: 'config/templates/[name].js',

// this is going to be add-on code, so it doesn't need the trappings of a full module (and in fact actively
Expand All @@ -47,6 +42,9 @@ export default [

packageSpecificConfig: {
output: {
// Preserve the original file structure (i.e., so that everything is still relative to `src`)
entryFileNames: 'config/loaders/[name].js',

// make it so Rollup calms down about the fact that we're combining default and named exports
exports: 'named',
},
Expand Down
527 changes: 0 additions & 527 deletions packages/nextjs/src/config/loaders/ast.ts

This file was deleted.

223 changes: 0 additions & 223 deletions packages/nextjs/src/config/loaders/dataFetchersLoader.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/nextjs/src/config/loaders/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
export { default as prefixLoader } from './prefixLoader';
export { default as dataFetchersLoader } from './dataFetchersLoader';
export { default as proxyLoader } from './proxyLoader';
49 changes: 0 additions & 49 deletions packages/nextjs/src/config/loaders/parser.ts

This file was deleted.

30 changes: 0 additions & 30 deletions packages/nextjs/src/config/templates/dataFetchersLoaderTemplate.ts

This file was deleted.

Loading