Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(utils): window and self are no longer required for global object detection? #5913

Closed
wants to merge 1 commit into from
Closed

ref(utils): window and self are no longer required for global object detection? #5913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions packages/utils/src/global.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,10 @@ function isGlobalObj(obj: { Math?: Math }): any | undefined {
return obj && obj.Math == Math ? obj : undefined;
}

// When our minimum supported version of node.js is v12 this can become simply globalThis
const GLOBAL =
(typeof globalThis == 'object' && isGlobalObj(globalThis)) ||
// eslint-disable-next-line no-restricted-globals
(typeof window == 'object' && isGlobalObj(window)) ||
(typeof self == 'object' && isGlobalObj(self)) ||
(typeof global == 'object' && isGlobalObj(global)) ||
(function (this: any) {
return this;
})() ||
{};

/**
Expand Down