ref(tracing): Deprecate tracingOrigins
#6176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
force-pushed
the
deprecate/tracingOrigins
branch
from
6f59c40
to
4c07f8b
Compare
Lms24
approved these changes
Nov 10, 2022
9 tasks
AbhiPrasad
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #5285
This PR:
tracingOriginsand points out the new properties that replace ittracingOriginsMy best guess is the logged warning about no supplied
tracingOriginswas due to the fact that it's default limited span creation and the default might not be relaxed enough. Since now span creation in controlled byshouldCreateSpanForRequestwhich defaults to always creating spans, this warning seems redundant. Users are now only likely to seek out tracing options to reduce the number of spans or stop header attachment if it's causing them CORS issues.