-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e): Add create-remix-app test #8286
Conversation
size-limit report 📦
|
You need to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the two small comments this looks good to me! :) Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need lockfiles in the e2e tests!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get rid of the favicon as it is not really necessary to any tests!
This Pull Request introduces the 'create remix' app to our end-to-end (e2e) tests. Currently, the focus is on validating if the build passes using the latest version of our remix SDK. However, in the future, we can extend these tests to encompass additional scenarios such as verifying exception handling, transaction processing, and more.
The primary goal of this PR is to prevent the release of our remix's SDK packages with ESM-related errors, such as the one mentioned in GitHub issue #5351