ref(nextjs): Set propagation context for tracing #8426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
lforst,
a team and
stephanie-anderson
and removed request for
a team
size-limit report 📦
|
AbhiPrasad
force-pushed
the
abhi-twp-nextjs
branch
from
6bc7527
to
733bca8
Compare
lforst
approved these changes
Jun 30, 2023
| } | ||
|
|
||
| getCurrentHub().getScope().setPropagationContext(propagationContext); |
There was a problem hiding this comment.
m: Since this function is currently pure i would move this into nextRouterInstrumentation directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #8352
start using
tracingContextFromHeaders(first used in #8422) to simplify how trace context is generated in server and client-side nextjs. Then set the propagation context accordingly.