-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(tracing): Add necessary helpers for using propagation context on outgoing headers #8434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
AbhiPrasad
changed the title
ref(tracing): Add propagation getter to scope
ref(tracing): Add necessary helpers for using propagation context on outgoing headers
Jun 30, 2023
mydea
reviewed
Jun 30, 2023
Lms24
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
experiments here: #8433
In preparation for Part 3 of #8352 (which involves creating
sentry-trace
/baggage
when a span does not exist and attaching them to outgoing requests/meta tags), this PR adds some helpers. Notably it adds:PropagationContext
on the scopegenerateSentryTraceHeader
, which will be used to dynamically createsentry-trace
headers, regardless of if there is a span or notgetDynamicSamplingContextFromClient
, which is used to generate dynamic sampling context from a client directly (instead of having to go through a transaction)This PR also updates
extractTraceparentData
anddynamicSamplingContextToSentryBaggageHeader
to be more liberal about the values it takes so we can better accommodate the new flows we are going to add.Next up - we're updating Undici/Node HTTP! Then we move on to Next.js, Remix, Sveltekit, Serverless - and we should be good to go 🚀